Skip to content

Commit 763c907

Browse files
committed
move all model interface outside of R command
1 parent 5f62328 commit 763c907

File tree

2 files changed

+22
-26
lines changed

2 files changed

+22
-26
lines changed

Eiger.py

+22-25
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@
2828
Model = namedtuple('Model', ['metric_names', 'means', 'stdevs',
2929
'rotation_matrix', 'kmeans', 'models'])
3030

31-
def r_import(args):
32-
database.addModelFromFile(args.database, args.file, 'R', args.description)
31+
def import_model(args):
32+
database.addModelFromFile(args.database, args.file, args.source_name, args.description)
3333

34-
def r_export(args):
34+
def export_model(args):
3535
database.dumpModelToFile(args.database, args.file, args.id)
3636

3737
def list_models(args):
@@ -349,9 +349,14 @@ def convert(args):
349349
help='list available models in the Eiger DB',
350350
description='List available models in the Eiger DB')
351351
list_model_parser.set_defaults(func=list_models)
352-
r_parser = subparsers.add_parser('R',
353-
help='interact with the R language for modeling',
354-
description='Interact with the R language for modeling')
352+
import_model_parser = subparsers.add_parser('import',
353+
help='import model file into the Eiger DB',
354+
description='Import model file into the Eiger DB')
355+
import_model_parser.set_defaults(func=import_model)
356+
export_model_parser = subparsers.add_parser('export',
357+
help='export model from Eiger DB to file',
358+
description='Export model from Eiger DB to file')
359+
export_model_parser.set_defaults(func=export_model)
355360

356361
"""TRAINING ARGUMENTS"""
357362
train_parser.add_argument('database', type=str, help='Name of the database file')
@@ -421,33 +426,25 @@ def convert(args):
421426
convert_parser.add_argument('output', type=str,
422427
help='Name of output model to convert to')
423428

424-
"""LIST-MODEL ARGUMENTS"""
429+
"""LIST ARGUMENTS"""
425430
list_model_parser.add_argument('database', type=str, help='Name of the database file')
426431

427-
"""R-MODEL ARGUMENTS"""
428-
r_subparser = r_parser.add_subparsers(title='subcommands')
429-
"""R IMPORT ARGUMENTS"""
430-
r_import_parser = r_subparser.add_parser('import',
431-
help='import R model file into the Eiger DB',
432-
description='Import R model file into the Eiger DB')
433-
r_import_parser.set_defaults(func=r_import)
434-
r_import_parser.add_argument('database', type=str,
432+
"""IMPORT ARGUMENTS"""
433+
import_model_parser.add_argument('database', type=str,
435434
help='Name of the database file')
436-
r_import_parser.add_argument('file', type=str,
435+
import_model_parser.add_argument('file', type=str,
437436
help='Name of the model file to import')
438-
r_import_parser.add_argument('--description', type=str,
437+
import_model_parser.add_argument('source_name', type=str,
438+
help='Name of the source of the model (ie Eiger)')
439+
import_model_parser.add_argument('--description', type=str,
439440
default='',
440441
help='String to describe the model')
441-
"""R EXPORT ARGUMENTS"""
442-
r_export_parser = r_subparser.add_parser('export',
443-
help='export R model from Eiger DB to file',
444-
description='Export R model from Eiger DB to file')
445-
r_export_parser.set_defaults(func=r_export)
446-
r_export_parser.add_argument('database', type=str,
442+
"""EXPORT ARGUMENTS"""
443+
export_model_parser.add_argument('database', type=str,
447444
help='Name of the database file')
448-
r_export_parser.add_argument('id', type=int,
445+
export_model_parser.add_argument('id', type=int,
449446
help='ID number identifying which model in the database to export ')
450-
r_export_parser.add_argument('file', type=str,
447+
export_model_parser.add_argument('file', type=str,
451448
help='Name of the file to export into')
452449

453450
args = parser.parse_args()

eiger/database.py

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ def addModelFromFile(database_name, model_file, source_name, description=''):
2525
with open(model_file, 'rb') as input_file:
2626
ablob = input_file.read()
2727
cmd = 'INSERT INTO models(description,source_id,data) VALUES("' + str(description) + '",' + str(source_id[0]) + ',?)'
28-
print cmd
2928
conn.execute(cmd, [sqlite3.Binary(ablob),])
3029
conn.commit()
3130

0 commit comments

Comments
 (0)