Skip to content

Commit 2d48bde

Browse files
authored
docs: fixed typos (#14)
Signed-off-by: Tomer Figenblat <[email protected]>
1 parent 807a659 commit 2d48bde

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

CONTRIBUTING.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,16 @@ and the [tsconfig.json](tsconfig.json) configuration file. Also note the _TypeSc
6262
Use [java_maven.js](src/providers/java_maven.js) as an example to get you started.
6363
* Import the new _Provider_ and list in the in _availableProviders_ array in [provider.js](src/provider.js).
6464
* Update the _choices_ configuration for the _manifest-name_ positional argument in [cli.js](src/cli.js).
65+
* Add Integration Test scenarios for the added provider in [integration/langs](integration/langs).
66+
Use the [java scenarios](integration/langs/java) as an example.
6567
* Update the documentation. This document and [README.md](README.md).
6668

69+
### Integration Tests
70+
71+
WIP
72+
73+
> We currently run integration tests against the actual production _Backend_, this will be replaced by opting for a _Mock Server_.
74+
6775
## Certificate of Origin
6876

6977
By contributing to this project you agree to the Developer Certificate of

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ with the <strong>read:packages</strong> scope<br/>
2525

2626
<p>
2727

28-
Add the following line to the <em>.npmrc</em> file in your user home:<br/>
29-
See [GH Docs](https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-npm-registry#authenticating-with-a-personal-access-token)
28+
Add the following line to the <em>.npmrc</em> file in your user home (
29+
See [GH Docs](https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-npm-registry#authenticating-with-a-personal-access-token)):
3030

3131
```text
3232
//npm.pkg.github.com/:_authToken=<your-ghp-token-goes-here>
@@ -39,7 +39,7 @@ See [GH Docs](https://docs.github.com/en/packages/working-with-a-github-packages
3939
<h3>Usage</h3>
4040
<p>
4141
Instruct <em>NPM</em> to look in <em>GHPR</em> for the <em>RHEcosystemAppEng</em> namespace.<br/>
42-
Add <code>@RHEcosystemAppEng:registry=https://npm.pkg.github.com</code> to <em>.npmrc</em> in either the project root or user home:
42+
Add <code>@RHEcosystemAppEng:registry=https://npm.pkg.github.com</code> to <em>.npmrc</em> in the project root or user home:
4343

4444
```shell
4545
echo "@RHEcosystemAppEng:registry=https://npm.pkg.github.com" >> .npmrc
@@ -49,7 +49,7 @@ echo "@RHEcosystemAppEng:registry=https://npm.pkg.github.com" >> .npmrc
4949

5050
<ul>
5151

52-
<li>Use as ECM Module</li>
52+
<li>Use as ESM Module</li>
5353
<p>
5454

5555
```shell

0 commit comments

Comments
 (0)