[V2] Can not move or select views/elements inside TabView

[FireDragon91245]

Maybe i have overread some documentation or discusion but i didnt find a way to select the button inside the tab,
im on TGD dev-4401 with library dev-4401
When trying right click or drag and drop on an element inside the tab it always selects the TabView itself and does not allow to "breaking trough" to the nested components

Tried with Label, Button, Combo Box, Chechbox and TableView

Thx in advance.

[tznind]

Hmn yes I see, I wonder if the View the tab hosts does not have CanFocus...

Modifying designer cs doesn't change it - I will have to look into this deeper.

I will first update to latest nuget package - but v2 has had many big breaking changes since I last updated

See #314 ><

[tznind]

Ok bug still appears even in latest version of the codebase on v2.

The issue is that:

View.GetViewsAtLocation(Application.Top,screenPoint)

does not return the button even when clicking directly on it.

[tznind]

Ok yes the problem is that we are seeing false for CanFocus as I expected in beginning

I added a watch for

((TabView)Application.Top.SubViews.ElementAt(0).SubViews.ElementAt(0)).Tabs.ElementAt(0).View.SubViews.ElementAt(0).ViewportToScreen(new Point(0,0))

The tab 1 has its view:

((TabView)Application.Top.SubViews.ElementAt(0).SubViews.ElementAt(0)).Tabs.ElementAt(0).View

CanFocus is false

[tznind]

Its strange, when you click down on the button it gets selected but when you release or drag it seems to loose that the button is selectable/selected.

[BDisp]

It's needed to create unit tests for drag and drop views in the Terminal.Gui to prevent this breaking changes.

[tznind]

Doesn't seem to be an issue in core lib:

    public partial class MyTabView : Window
    {

        private Terminal.Gui.Views.TabView tabView;

        public Terminal.Gui.Views.Button button;

        public void InitializeComponent ()
        {
            this.button = new Terminal.Gui.Views.Button ();
            this.tabView = new Terminal.Gui.Views.TabView ();
            this.Width = Dim.Fill (0);
            this.Height = Dim.Fill (0);
            this.X = 0;
            this.Y = 0;
            this.Visible = true;
            this.Arrangement = Terminal.Gui.ViewBase.ViewArrangement.Fixed;
            this.CanFocus = false;
            this.ShadowStyle = Terminal.Gui.ViewBase.ShadowStyle.None;
            this.TextAlignment = Terminal.Gui.ViewBase.Alignment.Start;
            this.tabView.Width = 67;
            this.tabView.Height = 12;
            this.tabView.X = 11;
            this.tabView.Y = 12;
            this.tabView.Visible = true;
            this.tabView.Arrangement = Terminal.Gui.ViewBase.ViewArrangement.Fixed;
            this.tabView.CanFocus = true;
            this.tabView.ShadowStyle = Terminal.Gui.ViewBase.ShadowStyle.None;
            this.tabView.Data = "tabView";
            this.tabView.TextAlignment = Terminal.Gui.ViewBase.Alignment.Start;
            this.tabView.MaxTabTextWidth = 30u;
            this.tabView.Style.ShowBorder = true;
            this.tabView.Style.ShowTopLine = true;
            this.tabView.Style.TabsOnBottom = false;
            Terminal.Gui.Views.Tab tabViewtab1;
            tabViewtab1 = new Terminal.Gui.Views.Tab ();
            tabViewtab1.DisplayText = "Tab1";
            tabViewtab1.View = new View ();
            tabViewtab1.View.Width = Dim.Fill ();
            tabViewtab1.View.Height = Dim.Fill ();
            this.button.Width = Dim.Auto ();
            this.button.Height = Dim.Auto ();
            this.button.X = 11;
            this.button.Y = 3;
            this.button.Visible = true;
            this.button.Arrangement = Terminal.Gui.ViewBase.ViewArrangement.Fixed;
            this.button.CanFocus = true;
            this.button.ShadowStyle = Terminal.Gui.ViewBase.ShadowStyle.Opaque;
            this.button.Data = "button";
            this.button.Text = "Heya";
            this.button.TextAlignment = Terminal.Gui.ViewBase.Alignment.Center;
            this.button.IsDefault = false;
            tabViewtab1.View.Add (this.button);
            tabView.AddTab (tabViewtab1, false);
            Terminal.Gui.Views.Tab tabViewtab2;
            tabViewtab2 = new Terminal.Gui.Views.Tab ();
            tabViewtab2.DisplayText = "Tab2";
            tabViewtab2.View = new View ();
            tabViewtab2.View.Width = Dim.Fill ();
            tabViewtab2.View.Height = Dim.Fill ();
            tabView.AddTab (tabViewtab2, false);
            this.tabView.ApplyStyleChanges ();
            this.Add (this.tabView);
        }
    }

    private static int Main (string [] args)
    {

        Application.Init ();
        var tv = new MyTabView ();
        tv.InitializeComponent ();

        var lbl = new Label ()
        {
            Width = 10
        };

        Application.MouseEvent += (s, e) =>
                                  {
                                      var views = View.GetViewsAtLocation (Application.Top, e.ScreenPosition);
                                      lbl.Text = views?.LastOrDefault ()?.ToString ();
                                  };
        tv.Add (lbl);
        Application.Run (tv);

        Application.Shutdown ();

        return 0;
	}

[tznind]

This is the problem, the ignoring code is ignoring too much

Ignoring is most important when dragging a view. For example if we click and drag a button into a View then we want the hit test to ignore the button being dragged.

But also we want to ignore certain other non designable views... this is where the issue is I will investigate how to fix

[tznind]

In fact just removing the non designable additions makes problem go away but I will need to look for side effects

  public static View? HitTest(this View w, MouseEventArgs m, out bool isBorder, out bool isLowerRight, params View[] ignoring)
  {
-    ignoring = ignoring.Union(w.GetAllNonDesignableSubviews()).ToArray();

      // hide the views while we perform the hit test
      foreach (View v in ignoring)
      {
          v.Visible = false;
      }

[BDisp]

Do you think is due the button moving down and loose focus?

[tznind]

No, its TGD code that I showed above, It seems good to remove it but I need to look to see why it was added to begin with and if the use case for that still applies

[tznind]

Ok I have made a change to remove this line as it doesn't look good and the git blame calls out the changes as potentially dangerous too.

Not sure why the issue didn't surface till now.

Please try installing TerminalGuiDesigner.2.0.0-develop.4402.nupkg Note that for this version you still want to target 4400 of terminal gui.

I will continue with the radical update in #314 which will add support for ~4519 and that will likely be the next version but it will not be in any way backwards compatible:

• New version will drop color scheme modification support (this is now intended to happen via themes in core lib)
• New namespaces etc

[FireDragon91245]

Works as expected now,

@tznind & @BDisp thx for the quick resoltution and your hard work on this amazing project

[BDisp]

It's only thanks to @tznind great work.