Skip to content

Fix new lint from Python 3.12 #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix new lint from Python 3.12 #175

wants to merge 1 commit into from

Conversation

@duncanmmacleod
Copy link
Member

@duncanmmacleod duncanmmacleod commented Oct 27, 2023

This PR fixes new lint exposed by running flake8 with Python 3.12.

@duncanmmacleod duncanmmacleod self-assigned this Oct 27, 2023
@duncanmmacleod duncanmmacleod added the pr:bug-fix Changes fix a bug, or a change unrelated to the public API label Oct 27, 2023
@duncanmmacleod duncanmmacleod added this to the pyomicron 2.0.7 milestone Oct 27, 2023
@codecov
Copy link

codecov bot commented Oct 27, 2023 •
edited
Loading

Codecov Report

Merging #175 (4d30a0a) into master (62e4c52) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #175   +/-   ##
=======================================
  Coverage   35.12%   35.12%           
=======================================
  Files          30       30           
  Lines        2941     2941           
=======================================
  Hits         1033     1033           
  Misses       1908     1908
Flag Coverage Δ
Conda 35.12% <0.00%> (ø)
Linux 35.12% <0.00%> (ø)
macOS 35.12% <0.00%> (ø)
python3.10 35.12% <0.00%> (ø)
python3.11 35.12% <0.00%> (ø)
python3.9 35.14% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
omicron/cli/merge_with_gaps.py 0.00% <0.00%> (ø)
omicron/cli/process.py 11.70% <0.00%> (ø)
omicron/cli/status.py 17.31% <0.00%> (ø)
omicron/data.py 21.93% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@duncanmmacleod duncanmmacleod removed their assignment Oct 27, 2023
@duncanmmacleod duncanmmacleod added omicron.data Related to the omicron.data module script:omicron-process Related to the omicron-process script script:omicron-status Related to the omicron-status script labels Oct 27, 2023
@duncanmmacleod duncanmmacleod requested a review from areeda October 27, 2023 13:18
@duncanmmacleod duncanmmacleod mentioned this pull request Oct 27, 2023
Merged
@duncanmmacleod
Copy link
Member Author

duncanmmacleod commented Nov 22, 2023

Ping @areeda.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@areeda areeda Awaiting requested review from areeda

Assignees

@areeda areeda

Labels

omicron.data Related to the omicron.data module pr:bug-fix Changes fix a bug, or a change unrelated to the public API script:omicron-process Related to the omicron-process script script:omicron-status Related to the omicron-status script

Projects

None yet

Milestone

pyomicron 2.0.7

Development

Successfully merging this pull request may close these issues.

2 participants

@duncanmmacleod @areeda