feat(parse): Begin debugging leaks and a way to free the array in itself

Author: h4rl

.github/workflows/ossf.yml

@@ -0,0 +1,52 @@
+# This workflow uses actions that are not certified by GitHub. They are provided
+# by a third-party and are governed by separate terms of service, privacy
+# policy, and support documentation.
+
+name: OSSF Scorecard analysis workflow
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    branches:
+      - main
+
+permissions: read-all
+
+jobs:
+  analysis:
+    name: Scorecard analysis
+    runs-on: ubuntu-latest
+    permissions:
+      # Needed if using Code scanning alerts
+      security-events: write
+      # Needed for GitHub OIDC token if publish_results is true
+      id-token: write
+
+    steps:
+      - name: "Checkout code"
+        uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4.1.4
+        with:
+          persist-credentials: false
+
+      - name: "Run analysis"
+        uses: ossf/scorecard-action@0864cf19026789058feabb7e87baa5f140aac736 # v2.3.1
+        with:
+          results_file: results.sarif
+          results_format: sarif
+          publish_results: true
+
+      # Upload the results as artifacts (optional). Commenting out will disable uploads of run results in SARIF
+      # format to the repository Actions tab.
+      - name: "Upload artifact"
+        uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
+        with:
+          name: SARIF file
+          path: results.sarif
+          retention-days: 5
+
+      # required for Code scanning alerts
+      - name: "Upload to code scanning"
+        uses: github/codeql-action/upload-sarif@1b1aada464948af03b950897e5eb522f92603cc2 # v3.24.9
+        with:
+          sarif_file: results.sarif

README.md

@@ -1,6 +1,7 @@
 # exMeteo
 
 ![[LICENSE](https://github.com/h4rldev/exmeteo/blob/main/LICENSE)](https://img.shields.io/github/license/h4rldev/exmeteo?style=flat-square)
+![[OpenSSF Scorecard](https://securityscorecards.dev/viewer/?uri=github.com/h4rldev/exmeteo)](https://api.securityscorecards.dev/projects/github.com/h4rldev/exmeteo/badge?style=flat-square)
 
 
 > [!CAUTION]

justfile

@@ -22,4 +22,3 @@ default:
 @debug name="exmeteo":
   just compile-debug {{name}}
   just link {{name}}
-  gdb ./bin/{{name}}

src/exmeteo/cache.c

@@ -0,0 +1,7 @@
+#include "cache.h"
+
+cJSON *read_from_cache(FILE *cache); 
+
+int write_to_json(char* filename, cJSON *json) {
+  return 0;
+}

src/exmeteo/cache.h

@@ -0,0 +1,26 @@
+#ifndef CACHE_H_INCLUDED
+#define CACHE_H_INCLUDED
+
+#include <cjson/cJSON.h>
+#include <stdio.h>
+#include <stdlib.h>
+
+#ifdef _WIN32
+
+#define CACHE_DIR() getenv("APPDATA") "\\exmeteo\\"
+
+#elif __linux__
+
+#define CACHE_DIR() getenv("HOME") "/.cache/exmeteo/"
+
+#else
+  #error "Unsupported Operating System, use a normal os, loser"
+#endif
+
+cJSON *read_from_cache(FILE *cache);
+
+int write_to_json(char *filename, cJSON *json);
+int update_cache(char *api_key);
+int clear_cache();
+
+#endif

src/exmeteo/cli.c

@@ -1,5 +1,6 @@
 #include "cli.h"
 #include "parse.h"
+#include <curl/curl.h>
 #include <stdio.h>
 
 #ifdef _WIN32
@@ -64,7 +65,7 @@ const char* flags[10] = {
   "--version",          // 3 version-flag
   "-v",                 // 4 shorterm for version
   "--convert-currency", // 5 currency-converter flag
-  "--currenct-convert", // 6 currency-converter flag
+  "--currency-convert", // 6 currency-converter flag
   "--convert",          // 7 shorterm for currency-converter
   "--currency",         // 8 shorterm for currency-converter
   "-c",                 // 9 extra shorterm for currency-converter
@@ -123,9 +124,11 @@ int print_help(char **argv[]) {
 
   char* help[3]     = {"--help", "-h", "-?"};
   char* version[2]  = {"--version", "-v"};
+  char* currency[5] = {"--convert-currency", "--currency-convert", "--convert", "--currency", "-c"};
 
   info_for_flag(help, 3, GREEN, "Prints this message.", YELLOW);
   info_for_flag(version, 2, GREEN, "Prints program version.", YELLOW);
+  info_for_flag(currency, 5, GREEN, "Convert one currency to another", YELLOW);
 
   print_line("-");
 
@@ -143,6 +146,7 @@ int print_version(void) {
 int init(int argc, char *argv[]) {
   char *user = getUsername();
 
+
   int flag = compare_flags(argv);
   switch (flag) {
     case 0:
@@ -163,7 +167,11 @@ int init(int argc, char *argv[]) {
       char *api_key = "966eb565013e92b110e1cf0d";
       char ***array = currency__get_codes(api_key);
       printf("got array hopefully\n");
-      printf("%s", array[0][1]);
+      int array_length = sizeof(array) / sizeof(array[0]);
+      printf("array len = %d", array_length);
+      printf("%s \n", array[0][1]);
+      free_2D_string_array(array, 162);
+      printf("size of char *: %lu \nsize of char **: %lu \nsize of char ***: %lu", sizeof(char *), sizeof(char **), sizeof(char ***));
       break;
   };
 

src/exmeteo/parse.c

@@ -10,6 +10,7 @@ cJSON *currency__get_json_value(char* api_key, char* value) {
 
   char *response = req(url);
   size_t response_length = (size_t)strlen(response);
+  printf("response length: %lu", response_length);
 
   cJSON *json = cJSON_ParseWithLength(response, response_length);
   if (! json) {
@@ -19,28 +20,11 @@ cJSON *currency__get_json_value(char* api_key, char* value) {
     }
     return 0;
   }
-  cJSON *json_value = cJSON_GetObjectItemCaseSensitive(json, value);  
+  cJSON *json_value = cJSON_GetObjectItemCaseSensitive(json, value);
+  free(response);
   return json_value;
 }
 
-char ***allocate_2D_string_array(int totalStrings, int stringSize) {
-    // Allocate memory for the outer array
-    printf("allocating %lu to array\n", totalStrings * sizeof(char **));
-    char ***stringList = (char ***)malloc(totalStrings * sizeof(char **));
-
-    // Allocate memory for each inner array
-    for (int i = 0; i < totalStrings; i++) {
-        stringList[i] = (char **)malloc((2 * sizeof(char*)));
-
-        // Allocate memory for each string
-        for (int j = 0; j < 2; j++) {
-            stringList[i][j] = (char *)malloc(stringSize);
-        }
-    }
-
-    return stringList;
-}
-
 void free_2D_string_array(char ***stringList, int totalStrings) {
   for (int i = 0; i < totalStrings; i++) {
     for (int j = 0; j < 2; j++) {
@@ -63,9 +47,8 @@ char*** currency__get_codes(char *api_key) {
   }
   // Determine the size of the JSON array
   int size = cJSON_GetArraySize(codes);
-
     // Allocate memory for the 2D array
-  char ***currency_codes = (char ***)malloc((size * sizeof(char ***)));
+  char ***currency_codes = (char ***)malloc((size * sizeof(char **)));
     // Iterate over the JSON array and store the strings in the 2D array
   for (int i = 0; i < size; i++) {
     cJSON *item = cJSON_GetArrayItem(codes, i);
@@ -78,28 +61,24 @@ char*** currency__get_codes(char *api_key) {
     int code_size = (strlen(code_str) + 1);
     int name_size = (strlen(name_str) + 1);
 
-    currency_codes[i] = (char **)malloc((2 * sizeof(char **)));
+    currency_codes[i] = (char **)malloc((2 * sizeof(char *)));
     printf("Allocating currency_codes[%d][0]..", i);
     currency_codes[i][0] = (char *)malloc(code_size); // +1 for the null terminator
     printf("Allocating currency_codes[%d][1]..", i);
     currency_codes[i][1] = (char *)malloc(name_size); // +1 for the null terminator
 
+
     strncpy(currency_codes[i][0], code_str, code_size);
     strncpy(currency_codes[i][1], name_str, name_size);
-    cJSON_free(item);
-    cJSON_free(code);
-    cJSON_free(name);
-    cJSON_free(code_str);
-    cJSON_free(name_str);
   }
 
   // Print the 2D array to verify
-  //for (int i = 0; i < size; i++) {
+  // for (int i = 0; i < size; i++) {
   //  printf("[\"%s\",\"%s\"]\n", currency_codes[i][0], currency_codes[i][1]);
   //}
 
   // Free the allocated memory
-  cJSON_Delete(codes);
+  cJSON_Delete(codes); 
   return currency_codes;
 }
 

src/exmeteo/req.c

@@ -30,7 +30,7 @@ WriteMemoryCallback(void *contents, size_t size, size_t nmemb, void *userp)
 
 char* req(char* url) {
   CURL *curl;
-  char *resp; 
+  char *resp = 0; 
   CURLcode response;
 
   struct MemoryStruct chunk;
@@ -65,6 +65,7 @@ char* req(char* url) {
   }
 
   strncpy(resp, chunk.memory, chunk.size);
+  free(chunk.memory);
   curl_easy_cleanup(curl);
   curl_global_cleanup();
   return resp;