-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for TypedArrays #27
Comments
Thanks for suggestion. If latest stable browsers and nodejs support for TypedArrays, I decide to support for TypedArrays. When I started this library, browsers didn't support for it. I think that this library should choose "just check the type of the input and act accordingly". |
According to this chart, all modern browsers (not just major) fully support And according to this other chart, Node.js has fully supported |
Yeah! Thank you! |
Glad this is on your radar. We've found at BeFunky that Supporting |
This would potentially also opening up for minimal reading: only reading file data incrementally up until the exif data ends. Currently one has to make an educated guess at a decent max size to stop reading, like mentioned here. |
I second this suggestion and say that TypedArrays became widely used facility to handle byte data. The support for it is almost universal nowadays. |
@mheskol This library is dead, ref #78. If you need the functionality, start a fork, implement and publish it to NPM to to share it with the world 🚀 If you do not need write-support, ExifReader is in active development and is maintained. |
Given the reduced memory consumption of using TypedArrays instead of UTF-16 encoded JavaScript strings, I can see this being a huge benefit for piexifjs.
Would you consider a pull-request that implemented support for this, and if so, how would you want to add it to your API? Would each of the existing functions just check the type of the input and act accordingly, or would you want separate functions for dealing with TypedArrays instead of strings?
The text was updated successfully, but these errors were encountered: