Updates to OData model change analyzer

Author: habbes

ODataModelChangeAnalyzer/ODataModelChangeAnalyzer/Changes.cs

@@ -17,8 +17,9 @@ record SchemaElementRemoved(IEdmElement Target) : IModelChange
     public ChangeKind ChangeKind => ChangeKind.Deletion;
 }
 
-record StructuredTypeChangedFromOpenToClose(IEdmElement Target, IEdmElement Original) : IModelChange
+record StructuredTypeChangedFromOpenToClose(IEdmStructuredType NewType, IEdmStructuredType OriginalType) : IModelChange
 {
+    public IEdmElement Target => NewType;
     public ChangeKind ChangeKind => ChangeKind.Modification;
 }
 

ODataModelChangeAnalyzer/ODataModelChangeAnalyzer/Program.cs

@@ -22,11 +22,19 @@
     Console.WriteLine(change);
     Console.WriteLine($"At line: {location!.LineNumber} pos: {location!.LinePosition}");
     Console.WriteLine();
+
+    var error = change switch
+    {
+        StructuredTypeChangedFromOpenToClose c => $"Changing the type {c.NewType.FullTypeName()} from open to close is a breaking change. To fix this, add the attribute OpenType=\"True\".",
+        _ => throw new NotSupportedException()
+    };
 }
 
 Console.WriteLine($"\nFound {count} changes.");
 
 
+
+
 IEdmModel ReadModel(string path)
 {
     using var file = File.OpenRead(path);
@@ -35,4 +43,6 @@ IEdmModel ReadModel(string path)
     return model;
 }
 
-record ChangeWithLocation(object Change, CsdlLocation? Location);
+record ChangeWithLocation(object Change, CsdlLocation? Location);
+
+record ConditionalBreakingChange<T>(Func<T, bool> IsBreaking);

ODataModelChangeAnalyzer/ODataModelChangeAnalyzer/TripPinUpdatedModel.csdl

@@ -1,13 +1,13 @@
-<edmx:Edmx xmlns:edmx="http://docs.oasis-open.org/odata/ns/edmx" Version="4.0">
+<edmx:Edmx xmlns:edmx="http://docs.oasis-open.org/odata/ns/edmx" Version="4.0" xmlns:ags="http://aggregator.microsoft.com/internal">
 	<script/>
 	<edmx:DataServices>
-		<Schema xmlns="http://docs.oasis-open.org/odata/ns/edm" Namespace="Microsoft.OData.SampleService.Models.TripPin">
+		<Schema xmlns="http://docs.oasis-open.org/odata/ns/edm" Namespace="Microsoft.OData.SampleService.Models.TripPin" xmlns:ags="http://aggregator.microsoft.com/internal">
 			<EnumType Name="PersonGender">
 				<Member Name="Male" Value="0"/>
 				<Member Name="Female" Value="1"/>
 				<Member Name="Unknown" Value="2"/>
 			</EnumType>
-			<ComplexType Name="City">
+			<ComplexType Name="City" ags:IsHidden="True">
 				<Property Name="CountryRegion" Type="Edm.String" Nullable="false"/>
 				<Property Name="Name" Type="Edm.String" Nullable="false"/>
 				<Property Name="Region" Type="Edm.String" Nullable="false"/>