Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoToSocial Version Parsing Regression Between 1.6.3 and 1.7.0 #390

Closed
gmemstr opened this issue Dec 14, 2024 · 0 comments · Fixed by #391
Closed

GoToSocial Version Parsing Regression Between 1.6.3 and 1.7.0 #390

gmemstr opened this issue Dec 14, 2024 · 0 comments · Fixed by #391

Comments

@gmemstr
Copy link
Contributor

gmemstr commented Dec 14, 2024

When using GTS with the instance-inject-mastodon-version configuration set to true, Mastodon.py >= 1.7.0 fails to figure out that it is compatible with API version >= 1.0.0.

The version being reported by https://botsinbox.net/api/v1/instance (as an example) is "3.5.3+0.17.3+git-6f4cb2f"

Based on https://github.com/halcy/Mastodon.py/blob/master/mastodon/internals.py#L614-L623, it looks like it's taking the 0.17.3 part of the version string rather than 3.5.5. This function was introduced here 1.6.3...1.7.0?diff=split&w=#diff-7ad1ef978b

halcy added a commit that referenced this issue Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant