wallet: check account ownership of bid TX when making reveal TX

Adds new method hasCoinByAccount(acct, hash, index) to txdb which
returns true if the coin (hash, index) is owned by account (number).
Adds this check to wallet.makeReveal() to prevent BIDs from other
wallet accounts being included as inputs to a new REVEAL TX from a
specific account.

Author: pinheadmz

lib/wallet/txdb.js

@@ -2250,6 +2250,20 @@ class TXDB {
     });
   }
 
+  /**
+   * Test whether an account owns a coin.
+   * @param {Number} acct
+   * @param {Hash} hash
+   * @param {Index} number
+   * @returns {Promise} - Returns Boolean.
+   */
+
+  hasCoinByAccount(acct, hash, index) {
+    assert(typeof acct === 'number');
+
+    return this.bucket.has(layout.C.encode(acct, hash, index));
+  }
+
   /**
    * Get hashes of all transactions in the database.
    * @param {Number} acct

lib/wallet/wallet.js

@@ -1747,12 +1747,18 @@ class Wallet extends EventEmitter {
   /**
    * Make a reveal MTX.
    * @param {String} name
+   * @param {String|Number} acct
    * @returns {MTX}
    */
 
-  async makeReveal(name) {
+  async makeReveal(name, acct) {
     assert(typeof name === 'string');
 
+    if (acct != null) {
+      assert((acct >>> 0) === acct || typeof acct === 'string');
+      acct = await this.getAccountIndex(acct);
+    }
+
     if (!rules.verifyName(name))
       throw new Error('Invalid name.');
 
@@ -1789,6 +1795,9 @@ class Wallet extends EventEmitter {
       if (!coin)
         continue;
 
+      if (acct != null && !await this.txdb.hasCoinByAccount(acct, hash, index))
+        continue;
+
       // Is local?
       if (coin.height < ns.height)
         continue;
@@ -1828,7 +1837,8 @@ class Wallet extends EventEmitter {
    */
 
   async _createReveal(name, options) {
-    const mtx = await this.makeReveal(name);
+    const acct = options ? options.account : null;
+    const mtx = await this.makeReveal(name, acct);
     await this.fill(mtx, options);
     return this.finalize(mtx, options);
   }