Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test command for working in tdd #1494

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Add a test command for working in tdd #1494

merged 1 commit into from
Feb 4, 2025

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Feb 4, 2025 •
edited
Loading

Context

Adding a test command that watches the unit tests related to the provided keyword

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to internal dev tooling

Related issues:

  1. Fixes Prepare testing environment for TDD - POC #1328

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

@sequba sequba self-assigned this Feb 4, 2025
@sequba sequba merged commit e4b6cbc into develop Feb 4, 2025
22 of 23 checks passed
@sequba sequba deleted the feature/test-command-for-tdd branch February 4, 2025 13:14
@sequba sequba linked an issue Feb 4, 2025 that may be closed by this pull request
Prepare testing environment for TDD - POC #1328
Open
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (9fff869) to head (e7c00f0).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1494   +/-   ##
========================================
  Coverage    97.22%   97.22%           
========================================
  Files          169      169           
  Lines        14523    14523           
  Branches      3169     3169           
========================================
  Hits         14120    14120           
  Misses         396      396           
  Partials         7        7

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025 •
edited
Loading

Performance comparison of head (e7c00f0) vs base (9fff869)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 548.67 | 533.98 | -2.68%
                                      Sheet B | 176.77 |  177.5 | +0.41%
                                      Sheet T | 152.16 | 152.61 | +0.30%
                                Column ranges | 528.41 | 525.33 | -0.58%
Sheet A:  change value, add/remove row/column |  16.09 |  15.29 | -4.97%
 Sheet B: change value, add/remove row/column | 138.18 | 146.15 | +5.77%
                   Column ranges - add column | 164.13 | 163.92 | -0.13%
                Column ranges - without batch | 486.23 | 488.07 | +0.38%
                        Column ranges - batch |  125.1 | 121.54 | -2.85%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sequba sequba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Prepare testing environment for TDD - POC
1 participant
@sequba