Support node v18 and drop node v12 (#97)

* Fix stream error propagation for node v16+

* Support node v18, drop node v12

* Update @hapi/file dependency to v3

Author: devinivy

.github/workflows/ci-module.yml

@@ -10,3 +10,5 @@ on:
 jobs:
   test:
     uses: hapijs/.github/.github/workflows/ci-module.yml@master
+    with:
+      min-node-version: 14

LICENSE.md

@@ -1,5 +1,6 @@
-Copyright (c) 2012-2019, Sideway Inc, and project contributors  
-Copyright (c) 2012-2014, Walmart.  
+Copyright (c) 2012-2022, Project contributors
+Copyright (c) 2012-2019, Sideway Inc
+Copyright (c) 2012-2014, Walmart.
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

lib/index.js

@@ -16,6 +16,7 @@ const Wreck = require('@hapi/wreck');
 
 
 const internals = {
+    kSubtext: Symbol('subtext'),
     decoders: {
         gzip: (options) => Zlib.createGunzip(options),
         deflate: (options) => Zlib.createInflate(options)
@@ -114,12 +115,12 @@ internals.parse = async function (req, tap, options, contentType) {
 internals.decoder = function (source, options) {
 
     const contentEncoding = source.headers['content-encoding'];
-    const decoders = options.decoders || internals.decoders;
+    const decoders = options.decoders ?? internals.decoders;
     if (!decoders.hasOwnProperty(contentEncoding)) {
         return source;
     }
 
-    const decoderOptions = options.compression && options.compression[contentEncoding] || null;
+    const decoderOptions = options.compression?.[contentEncoding] ?? null;
     const stream = decoders[contentEncoding](decoderOptions);
 
     const orig = stream.emit;
@@ -208,7 +209,7 @@ internals.object = function (options, payload, mime) {
     // Form-encoded
 
     if (mime === 'application/x-www-form-urlencoded') {
-        const parse = options.querystring || Querystring.parse;
+        const parse = options.querystring ?? Querystring.parse;
         return payload.length ? parse(payload.toString('utf8')) : {};
     }
 
@@ -306,7 +307,7 @@ internals.writeFile = function (req, options, stream) {
 
     const promise = new Promise((resolve, reject) => {
 
-        const path = File.uniqueFilename(options.uploads || Os.tmpdir());
+        const path = File.uniqueFilename(options.uploads ?? Os.tmpdir());
         const file = Fs.createWriteStream(path, { flags: 'wx' });
         const counter = new internals.Counter(options);
 

package.json

@@ -20,19 +20,19 @@
     ]
   },
   "dependencies": {
-    "@hapi/boom": "9.x.x",
-    "@hapi/bourne": "2.x.x",
-    "@hapi/content": "^5.0.2",
-    "@hapi/file": "2.x.x",
-    "@hapi/hoek": "9.x.x",
-    "@hapi/pez": "^5.0.1",
-    "@hapi/wreck": "17.x.x"
+    "@hapi/boom": "^10.0.0",
+    "@hapi/bourne": "^3.0.0",
+    "@hapi/content": "^6.0.0",
+    "@hapi/file": "^3.0.0",
+    "@hapi/hoek": "^10.0.0",
+    "@hapi/pez": "^6.0.0",
+    "@hapi/wreck": "^18.0.0"
   },
   "devDependencies": {
-    "@hapi/code": "8.x.x",
-    "@hapi/eslint-plugin": "5.x.x",
-    "@hapi/lab": "24.x.x",
-    "form-data": "3.x.x"
+    "@hapi/code": "^9.0.0",
+    "@hapi/eslint-plugin": "*",
+    "@hapi/lab": "^25.0.1",
+    "form-data": "^4.0.0"
   },
   "scripts": {
     "test": "lab -a @hapi/code -t 100 -L",

test/esm.js

@@ -0,0 +1,27 @@
+'use strict';
+
+const Code = require('@hapi/code');
+const Lab = require('@hapi/lab');
+
+
+const { before, describe, it } = exports.lab = Lab.script();
+const expect = Code.expect;
+
+
+describe('import()', () => {
+
+    let Subtext;
+
+    before(async () => {
+
+        Subtext = await import('../lib/index.js');
+    });
+
+    it('exposes all methods and classes as named imports', () => {
+
+        expect(Object.keys(Subtext)).to.equal([
+            'default',
+            'parse'
+        ]);
+    });
+});