Use harfbuzz's amalgam instead cmake

Author: ebraminio

.gitmodules

@@ -0,0 +1,3 @@
+[submodule "harfbuzz"]
+	path = harfbuzz
+	url = https://github.com/harfbuzz/harfbuzz

CMakeLists.txt

@@ -20,6 +20,8 @@ branches:
     - /^v\d+\.\d+.*$/
 
 install:
+  - cd %APPVEYOR_BUILD_FOLDER%
+  - git submodule update --init --recursive
   - SET PATH=%PYTHON%;%PYTHON%\Scripts;%PATH%
   - python -m pip install --upgrade pip
   - pip install cibuildwheel==1.1.0

appveyor.yml

@@ -4,8 +4,5 @@ requires = [
     "wheel",
     "setuptools_scm >= 2.1",
     "cython >= 0.28.1",
-    "scikit-build >= 0.9.0",
-    "cmake",
-    "ninja",
 ]
 build-backend = "setuptools.build_meta"

harfbuzz

@@ -1,7 +1,4 @@
 cython>=0.29.1
-scikit-build>=0.8.1
-cmake
-ninja
 
 # we need wheel >= 0.31.0 to support Markdown long_description
 wheel>=0.31

pyproject.toml

@@ -3,25 +3,36 @@
 from io import open
 import os
 import sys
-
+import platform
+from setuptools import Extension, setup
+from Cython.Build import cythonize
 
 here = os.path.abspath(os.path.dirname(__file__))
 
 # Get the long description from the README file
 with open(os.path.join(here, 'README.md'), encoding='utf-8') as f:
     long_description = f.read()
 
-cmake_args = []
-for option in ("CYTHON_LINETRACE", "CYTHON_ANNOTATE"):
-    value = os.environ.get(option)
-    if value is not None and bool(int(value)):
-        cmake_args.append("-D{}:BOOL=TRUE".format(option))
-
-# On Mac, require OSX >= 10.9 so we can use te new libc++ targeting C++11
-if sys.platform == "darwin":
-    cmake_args.append("-DCMAKE_OSX_DEPLOYMENT_TARGET:STRING=10.9")
+define_macros = [('HB_NO_MT', '1')]
+linetrace = False
+if int(os.environ.get('CYTHON_LINETRACE', '0')):
+    linetrace = True
+    define_macros.append(('CYTHON_TRACE_NOGIL', '1'))
+
+extra_compile_args = []
+if platform.system() != 'Windows':
+    extra_compile_args.append('-std=c++11')
+
+extension = Extension(
+    'uharfbuzz._harfbuzz',
+    define_macros=define_macros,
+    include_dirs=['harfbuzz/src'],
+    sources=['src/uharfbuzz/_harfbuzz.pyx', 'harfbuzz/src/harfbuzz.cc'],
+    language='c++',
+    extra_compile_args=extra_compile_args,
+)
 
-setup_params = dict(
+setup(
     name="uharfbuzz",
     use_scm_version={"write_to": "src/uharfbuzz/_version.py"},
     description="Streamlined Cython bindings for the harfbuzz shaping engine",
@@ -35,21 +46,10 @@
     packages=["uharfbuzz"],
     zip_safe=False,
     setup_requires=["setuptools_scm"],
-    cmake_args=cmake_args,
     python_requires=">=3.5",
+    ext_modules = cythonize(
+        extension,
+        annotate=bool(int(os.environ.get('CYTHON_ANNOTATE', '0'))),
+        compiler_directives={"linetrace": linetrace},
+    ),
 )
-
-
-if __name__ == "__main__":
-    import sys
-    # cibuildwheel calls setup.py --name to get the package name; no need
-    # to require scikit-build at that stage: it will be installed later with
-    # the rest of the build requirements. Also, creating an sdist can be done
-    # with plain setuptools since there is no cmake involved there, and we
-    # generate the manifest using setuptools_scm anyway.
-    args = sys.argv[1:]
-    if len(args) == 1 and {"--name", "sdist"}.intersection(args):
-        from setuptools import setup
-    else:
-        from skbuild import setup
-    setup(**setup_params)

requirements-dev.txt

@@ -1,6 +1,6 @@
 #cython: language_level=3
 from enum import IntEnum
-from charfbuzz cimport *
+from .charfbuzz cimport *
 from libc.stdlib cimport free, malloc
 from libc.string cimport const_char
 from typing import Callable, Dict, List, Tuple

setup.py

@@ -18,8 +18,6 @@ setenv =
 commands =
     !cov: pytest {posargs}
     cov: python setup.py develop
-    cov: python -c 'import shutil, glob; src = glob.glob("_skbuild/*/cmake-build/uharfbuzz-prefix/src/uharfbuzz-build/_harfbuzz.c"); src and shutil.copy(src[0], "src/uharfbuzz/_harfbuzz.c")'
-    cov: python -c 'import shutil, glob; src = glob.glob("_skbuild/*/cmake-build/uharfbuzz-prefix/src/uharfbuzz-build/_harfbuzz.html"); src and shutil.copy(src[0], "src/uharfbuzz/_harfbuzz.html")'
     cov: coverage run --parallel -m pytest {posargs}
 
 [testenv:coverage]