Require entropy sourcing to succeed #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduce a new method with a simplified call signature (directly returning a string), internally panic()'ing if the entropy read failed. For most security products, a faulty underlying RNG/entropy source should be considered a fatal error as it generally isn't (software) recoverable without additional operator input. The higher layers of our software likely shouldn't retrigger the request (or continue to other sensitive operations) without this being addressed. Signed-off-by: Alexander Scheel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce a new method with a simplified call signature (directly
returning a string), internally
panic()'ing if the entropy read failed.For most security products, a faulty underlying RNG/entropy source
should be considered a fatal error as it generally isn't (software)
recoverable without additional operator input. The higher layers of our
software likely shouldn't retrigger the request (or continue to other
sensitive operations) without this being addressed.
Signed-off-by: Alexander Scheel <[email protected]>This admittedly partially undoes 132dbc4 , with the argument that it was the right choice. But we allow consumers of the library which they want to use.