Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: golangci-lint fixes #188

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Chore: golangci-lint fixes #188

merged 1 commit into from
Feb 26, 2025

Conversation

SBGoods
Copy link
Contributor

@SBGoods SBGoods commented Feb 26, 2025

  • Replace max-per-linter with max-issues-per-linters
  • Replace exportloopref linter with copyloopvar
  • Replace tenv linter with usetesting

@SBGoods SBGoods requested a review from a team as a code owner February 26, 2025 16:41
austinvalle
austinvalle approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SBGoods SBGoods merged commit 426582d into main Feb 26, 2025
4 checks passed
@SBGoods SBGoods deleted the SBGoods/linting-fixes branch February 26, 2025 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinvalle austinvalle austinvalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SBGoods @austinvalle