Skip to content

Commit 9e15953

Browse files
authored
Merge pull request #42602 from hashicorp/b-billing-cost-management-global
AWS Billing and Cost Management services are global
2 parents 5357ad5 + 0f47066 commit 9e15953

12 files changed

+36
-20
lines changed

internal/service/bcmdataexports/export.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -453,7 +453,6 @@ func findExportByID(ctx context.Context, conn *bcmdataexports.Client, exportArn
453453
}
454454

455455
type exportResourceModel struct {
456-
framework.WithRegionModel
457456
Export fwtypes.ListNestedObjectValueOf[exportData] `tfsdk:"export"`
458457
ID types.String `tfsdk:"id"`
459458
Tags tftags.Map `tfsdk:"tags"`

internal/service/bcmdataexports/service_package_gen.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/service/billing/billing_service_account_data_source.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import (
1616
)
1717

1818
// @FrameworkDataSource("aws_billing_service_account", name="Service Account")
19-
// @Region(overrideEnabled=false)
2019
func newServiceAccountDataSource(context.Context) (datasource.DataSourceWithConfigure, error) {
2120
d := &billingServiceAccountDataSource{}
2221

internal/service/budgets/service_package_gen.go

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/service/ce/service_package_gen.go

Lines changed: 6 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/service/costoptimizationhub/enrollment_status.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,6 @@ func findEnrollmentStatus(ctx context.Context, conn *costoptimizationhub.Client)
248248
}
249249

250250
type enrollmentStatusResourceModel struct {
251-
framework.WithRegionModel
252251
ID types.String `tfsdk:"id"`
253252
Status types.String `tfsdk:"status"`
254253
IncludeMemberAccounts types.Bool `tfsdk:"include_member_accounts"`

internal/service/costoptimizationhub/preferences.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,6 @@ func findPreferences(ctx context.Context, conn *costoptimizationhub.Client) (*co
247247
}
248248

249249
type preferencesResourceModel struct {
250-
framework.WithRegionModel
251250
ID types.String `tfsdk:"id"`
252251
MemberAccountDiscountVisibility types.String `tfsdk:"member_account_discount_visibility"`
253252
SavingsEstimationMode types.String `tfsdk:"savings_estimation_mode"`

internal/service/costoptimizationhub/service_package_gen.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/service/cur/service_package_gen.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

internal/service/pricing/service_package_gen.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

names/data/names_data.hcl

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -861,6 +861,8 @@ service "bcmdataexports" {
861861
provider_package_correct = "bcmdataexports"
862862
doc_prefix = ["bcmdataexports_"]
863863
brand = "AWS"
864+
865+
is_global = true
864866
}
865867

866868
service "billing" {
@@ -887,6 +889,8 @@ service "billing" {
887889
provider_package_correct = "billing"
888890
doc_prefix = ["billing_"]
889891
brand = "AWS"
892+
893+
is_global = true
890894
}
891895

892896
service "billingconductor" {
@@ -961,6 +965,8 @@ service "ce" {
961965
provider_package_correct = "ce"
962966
doc_prefix = ["ce_"]
963967
brand = "AWS"
968+
969+
is_global = true
964970
}
965971

966972
service "chatbot" {
@@ -2334,6 +2340,8 @@ service "costoptimizationhub" {
23342340
provider_package_correct = "costoptimizationhub"
23352341
doc_prefix = ["costoptimizationhub_"]
23362342
brand = "AWS"
2343+
2344+
is_global = true
23372345
}
23382346

23392347
service "cur" {
@@ -2366,6 +2374,8 @@ service "cur" {
23662374
provider_package_correct = "cur"
23672375
doc_prefix = ["cur_"]
23682376
brand = "AWS"
2377+
2378+
is_global = true
23692379
}
23702380

23712381
service "dataexchange" {
@@ -6198,6 +6208,8 @@ service "pricing" {
61986208
provider_package_correct = "pricing"
61996209
doc_prefix = ["pricing_"]
62006210
brand = "AWS"
6211+
6212+
is_global = true
62016213
}
62026214

62036215
service "proton" {
@@ -8353,6 +8365,8 @@ service "budgets" {
83538365
provider_package_correct = "budgets"
83548366
doc_prefix = ["budgets_"]
83558367
brand = "AWS"
8368+
8369+
is_global = true
83568370
}
83578371

83588372
service "wellarchitected" {

website/docs/guides/enhanced-region-support.html.markdown

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -515,11 +515,18 @@ The following regional resources and data sources had a top-level `region` prior
515515
All resources for the following services are considered _global_:
516516

517517
* Account Management (`aws_account_*`)
518+
* Billing (`aws_billing_*`)
519+
* Billing and Cost Management Data Exports (`aws_bcmdataexports_*`)
520+
* Budgets (`aws_budgets_*`)
518521
* CloudFront (`aws_cloudfront_*` and `aws_cloudfrontkeyvaluestore_*`)
522+
* Cost Explorer (`aws_ce_*`)
523+
* Cost Optimization Hub (`aws_costoptimizationhub_*`)
524+
* Cost and Usage Report (`aws_cur_*`)
519525
* Global Accelerator (`aws_globalaccelerator_*`)
520526
* IAM (`aws_iam_*`, `aws_rolesanywhere_*` and `aws_caller_identity`)
521527
* Network Manager (`aws_networkmanager_*`)
522528
* Organizations (`aws_organizations_*`)
529+
* Price List (`aws_pricing_*`)
523530
* Route 53 (`aws_route53_*` and `aws_route53domains_*`)
524531
* Route 53 ARC (`aws_route53recoverycontrolconfig_*` and `aws_route53recoveryreadiness_*`)
525532
* Shield Advanced (`aws_shield_*`)
@@ -533,7 +540,6 @@ Some regional services have a subset of resources that are global:
533540
|---|---|---|
534541
| Audit Manager | Resource | `aws_auditmanager_organization_admin_account_registration` |
535542
| Backup | Resource | `aws_backup_global_settings` |
536-
| Billing | Data Source | `aws_billing_service_account` |
537543
| Chime SDK Voice | Resource | `aws_chimesdkvoice_global_settings` |
538544
| CloudTrail | Resource | `aws_cloudtrail_organization_delegated_admin_account` |
539545
| Detective | Resource | `aws_detective_organization_admin_account` |

0 commit comments

Comments
 (0)