Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: inline_policy deprecation don't have any reason #40143

Closed
ibaraki-douji opened this issue Nov 15, 2024 · 4 comments
Closed

[Bug]: inline_policy deprecation don't have any reason #40143

ibaraki-douji opened this issue Nov 15, 2024 · 4 comments
Labels
bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service. upstream Addresses functionality related to the cloud provider.

Comments

@ibaraki-douji
Copy link

Terraform Core Version

1.9.5

AWS Provider Version

5.76.0

Affected Resource(s)

aws_iam_role

Expected Behavior

inline_policy deprecation don't have any Reason for why it was deprecated
image

Actual Behavior

inline_policy should have the reason why it was deprecated and maybe also the new element that replace that deprecation

Relevant Error/Panic Output Snippet

No response

Terraform Configuration Files

resource "aws_iam_role" "role" {
  name = "${var.name}"
  inline_policy {
    name = "${var.name}"
    policy = jsonencode({...})
}

Steps to Reproduce

Open VSCode (with HCL extension)

Use the "aws_iam_role" resource with the "inline_policy" block

Look at the code and the "inline_policy" should be marked as deprecated without any reason

Debug Output

No response

Panic Output

No response

Important Factoids

No response

References

No response

Would you like to implement a fix?

None

@ibaraki-douji ibaraki-douji added the bug Addresses a defect in current functionality. label Nov 15, 2024
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@github-actions github-actions bot added service/iam Issues and PRs that pertain to the iam service. needs-triage Waiting for first response or review from a maintainer. labels Nov 15, 2024
@justinretzolk
Copy link
Member

Hey @ibaraki-douji 👋 Thank you for taking the time to raise this! It looks like this is a result of the deprecation message not being exposed by the SDK/Terraform Core in a way that allows the language server to retrieve that information (see hashicorp/vscode-terraform#1729). Upon running terraform plan, however, the deprecation message will be included in the output.

Since this is more of an upstream/language server issue, and not something that the AWS Provider team will need to make changes for at this time, I'm going to close this issue for now. If there are changes in the upstream behavior in the future that we need to make adjustments for, we'd be happy to take another look. In the meantime, if you experience any other unexpected behavior, please do let us know!

@justinretzolk justinretzolk added the upstream Addresses functionality related to the cloud provider. label Nov 15, 2024
Copy link

Warning

This issue has been closed, meaning that any additional comments are hard for our team to see. Please assume that the maintainers will not see them.

Ongoing conversations amongst community members are welcome, however, the issue will be locked after 30 days. Moving conversations to another venue, such as the AWS Provider forum, is recommended. If you have additional concerns, please open a new issue, referencing this one where needed.

@github-actions github-actions bot removed the needs-triage Waiting for first response or review from a maintainer. label Nov 15, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/iam Issues and PRs that pertain to the iam service. upstream Addresses functionality related to the cloud provider.
Projects
None yet
Development

No branches or pull requests

2 participants