Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Refactor tags into new package to align with azurerm provider #109

Closed
pbolduc opened this issue Oct 17, 2019 · 2 comments
Closed

Comments

@pbolduc
Copy link
Contributor

pbolduc commented Oct 17, 2019

The terraform-provider-azurerm provider has moved the tag schema, validation and other functions into separate package back in Aug 2019. Having the terraform-provider-azurerm provider diverge makes it more difficult to create new resources on Azure Stack (ie #50) that are derived from the Azure Cloud. If the model in the Azure Cloud has stabilized, I propose starting migrating to similar packages in Azure Stack.

This issue is specifically for tags. Separate issues can be created for other kinds.

The complete list :

terraform-provider-azurestack file terraform-provider-azurerm package
azurestack/locks.go azurerm/internal/locks
azurestack/tags.go azurerm/internal/tags
others?

Once the new package is committed, a sweep of the source code can be completed to update references.

pbolduc added a commit to pbolduc/terraform-provider-azurestack that referenced this issue Oct 17, 2019
pbolduc added a commit to pbolduc/terraform-provider-azurestack that referenced this issue Oct 17, 2019
pbolduc added a commit to pbolduc/terraform-provider-azurestack that referenced this issue Oct 17, 2019
@pbolduc
Copy link
Contributor Author

pbolduc commented Oct 25, 2019

Going to close this issue/PR for now. It seems there is the intention to add engineering effort on this teams to accelerate the development.

@pbolduc pbolduc closed this as completed Oct 25, 2019
@ghost
Copy link

ghost commented Nov 25, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant