[Task] Refactor locks into new package to align with azurerm provider

[pbolduc]

The terraform-provider-azurerm provider has moved the resource locking functionality into separate package back in Aug 2019. Having the terraform-provider-azurerm provider diverge makes it more difficult to create new resources on Azure Stack (ie #50) that are derived from the Azure Cloud. If the model in the Azure Cloud has stabilized, I propose starting migrating to similar packages in Azure Stack.

See issue #109

[pbolduc]

The locks package file is identical to the azurerm locks.go file. However, the azurerm locks package is internal. Ideally, both providers could use the same file. I will raise an issue in the azurerm repository.

$ make build
==> Checking that code complies with gofmt requirements...
go install
azurestack\resource_arm_loadbalancer_backend_address_pool.go:12:2: use of internal package github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/locks not allowed
make: *** [build] Error 1

[pbolduc]

Going to close this issue/PR for now. It seems there is the intention to add engineering effort on this teams to accelerate the development.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!