Adding data source subscription(s), new subscription client #156
+2,129
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katbyte
requested changes
Feb 23, 2022
There was a problem hiding this comment.
Thanks @redak-hash - we have a filling test here:
<div class="rightBlock expandedDetails" style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; float: right; background-color: rgba(245, 245, 245, 0.81); border-left-width: 5px; border-left-style: solid; border-left-color: rgb(255, 255, 255); border-bottom-width: 5px; border-bottom-style: solid; border-bottom-color: rgb(255, 255, 255); caret-color: rgb(31, 35, 38); color: rgb(31, 35, 38); font-family: system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen, Ubuntu, Cantarell, "Droid Sans", "Helvetica Neue", Arial, sans-serif; font-size: 13px;"><br class="Apple-interchange-newline"><div class="icon_before icon16 collapser collapser_expanded" title="Click to hide the details block" style="float: right; height: 2em; padding: 5px; cursor: pointer;"></div><div class="relatedBuildsWrapper" style="border-right-width: 3px; border-right-style: solid; border-right-color: white; float: right;">
| First failure: | | #11 | Changes (3) | 23 Feb 22 16:15
-- | -- | -- | -- | -- | --
<div id="div_iaa_17c32841381"></div></div></div><span style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; caret-color: rgb(31, 35, 38); color: rgb(31, 35, 38); font-family: system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen, Ubuntu, Cantarell, "Droid Sans", "Helvetica Neue", Arial, sans-serif; font-size: 13px; background-color: rgb(255, 255, 255); float: none; display: inline !important;"></span><span style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; caret-color: rgb(31, 35, 38); color: rgb(31, 35, 38); font-family: system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen, Ubuntu, Cantarell, "Droid Sans", "Helvetica Neue", Arial, sans-serif; font-size: 13px; background-color: rgb(255, 255, 255); float: none; display: inline !important;"></span><div class="testMetadata" id="testMetadata_tdi_17c3284137f" style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; caret-color: rgb(31, 35, 38); color: rgb(31, 35, 38); font-family: system-ui, -apple-system, BlinkMacSystemFont, "Segoe UI", Roboto, Oxygen, Ubuntu, Cantarell, "Droid Sans", "Helvetica Neue", Arial, sans-serif; font-size: 13px;"></div><pre class="fullStacktrace" id="fullStacktrace_260874_83867537089881702" style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; font-stretch: normal; font-size: 12px; line-height: 1.2em; font-family: Menlo, "Bitstream Vera Sans Mono", "Ubuntu Mono", Consolas, "Courier New", Courier, monospace; padding: 3px 3px 0px; color: darkred; margin-top: 0.5em; margin-bottom: 0.5em; white-space: pre-wrap; overflow-wrap: break-word;">Test Failed
------- Stdout: -------
=== RUN TestAccDataSourceSubscription_specific
=== PAUSE TestAccDataSourceSubscription_specific
=== CONT TestAccDataSourceSubscription_specific
testcase.go:110: Step 1/1 error: Check failed: Check 5/6 error: data.azurestack_subscription.specific: Attribute 'quota_id' expected to be set
--- FAIL: TestAccDataSourceSubscription_specific (3.94s)</pre>[](https://www.jetbrains.com/help/teamcity/2020.2/?First%20Failure)First failure: refs/pull/156/merge [#11 ](https://ci-oss.hashicorp.engineering/viewLog.html?buildId=260874&tab=buildResultsDiv&buildTypeId=AzureStack_TerraformProviderAzurestack_AZURESTACK_PR_STACK) [Changes (3)](https://ci-oss.hashicorp.engineering/viewLog.html?buildId=260874&tab=buildChangesDiv&buildTypeId=AzureStack_TerraformProviderAzurestack_AZURESTACK_PR_STACK) 23 Feb 22 16:15
Test Failed
------- Stdout: -------
=== RUN TestAccDataSourceSubscription_specific
=== PAUSE TestAccDataSourceSubscription_specific
=== CONT TestAccDataSourceSubscription_specific
testcase.go:110: Step 1/1 error: Check failed: Check 5/6 error: data.azurestack_subscription.specific: Attribute 'quota_id' expected to be set
--- FAIL: TestAccDataSourceSubscription_specific (3.94s)
|
Thank you for your review @katbyte , Regarding acceptance test failure, according to the azure rest api specs, the response should contain Do we remove those fields from data source schema even if they are expected "theoretically" ? |
rkhaled0
force-pushed
the
feature/bring-data-source-subscriptions
branch
from
b96c40e to
f6859f9
Compare
@katbyte , thank you for reviewing again, should be ok right now. |
|
|
rkhaled0
force-pushed
the
feature/bring-data-source-subscriptions
branch
from
f6859f9 to
b603899
Compare
|
Hello @katbyte , could you please review this PR ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring support to these following data sources:
azurestack_subscriptionazurestack_subscriptions