Bring resources (+data source) for role def & assignment #159
+6,494
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urestack_role_assignment
katbyte
requested changes
Mar 12, 2022
Comment on lines
+89
to
+98
| // "principal_type": { | ||
| // Type: schema.TypeString, | ||
| // Computed: true, | ||
| // }, | ||
|
|
||
| // "skip_service_principal_aad_check": { | ||
| // Type: schema.TypeBool, | ||
| // Optional: true, | ||
| // Computed: true, | ||
| // }, |
There was a problem hiding this comment.
instead of commenting them out could we just remove unsupported items?
Comment on lines
+159
to
+162
| // skipPrincipalCheck := d.Get("skip_service_principal_aad_check").(bool) | ||
| // if skipPrincipalCheck { | ||
| // properties.RoleAssignmentProperties.PrincipalType = authorization.ServicePrincipal | ||
| // } |
|
|
|
Is this PR still planned? Or is there anything that can be helped to get it along. We have a need for this specific resource to become available |
|
@ryanschaaf-dmc - this pr is waiting for the contributor to address the feedback |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Acceptance tests depend on this PR #156