Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extraPorts to the server's Service resource #1092

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

HernanGatta
Copy link

@HernanGatta HernanGatta commented Feb 20, 2025

Overview

This change allows one to specify additional ports in the Service resource created for the Vault pod(s).

The rationale is that, in our use case, we inject pods into certain kinds of workloads that in turn alter their traffic routing. As a result, the initial assumptions about networking no longer hold, and extra ports are necessary.

Based on a similar PR that added the same to the corresponding StatefulSet.

Testing

I added a new test and verified that my change works correctly, both via bats as well as on my own deployments.

@HernanGatta HernanGatta requested a review from a team as a code owner February 20, 2025 22:02
Copy link

hashicorp-cla-app bot commented Feb 20, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant