Adds manual and automated root rotation support #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fairclothjm
reviewed
Jan 30, 2025
| Invalidate: b.invalidate, | ||
| InitializeFunc: b.initialize, | ||
| Invalidate: b.invalidate, | ||
| RotateCredential: b.rotateRootCredential, |
There was a problem hiding this comment.
Did we ever land on a decision around what the API will look like when we add support for static roles? Presumably it will be backwards compatible with this one?
There was a problem hiding this comment.
We haven't landed on a decision, but approaches we have discussed should be backwards compatible. Either a net new addition to the framework.Backend to isolate static credential rotation methods (ex RotateStaticCredentials). If that feels like overload, we can extend support on this method itself to include static role rotations, and conditionally use either/or based on the rotation job type
vinay-gopalan
previously approved these changes
Feb 11, 2025
vinay-gopalan
previously approved these changes
Feb 11, 2025
vinay-gopalan
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Adds a path and handler for
/rotate-rootsimilar to gcp secrets.Adds support for new automated root rotation manager in Vault Enterprise.
Contributor Checklist
[ ] Add relevant docs to upstream Vault repository, or sufficient reasoning why docs won’t be added yet
My Docs PR Link
Example
[ ] Add output for any tests not ran in CI to the PR description (eg, acceptance tests)
[ ] Backwards compatible