Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource generation target #216

Merged
merged 11 commits into from
Jul 25, 2024

Conversation

vinay-gopalan
Copy link
Contributor

@vinay-gopalan vinay-gopalan commented Jun 10, 2024

Overview

Builds on #211 and fixes remaining broken resources.

Related Issues/Pull Requests

PR #211

@eh-steve
Copy link
Contributor

eh-steve commented Jul 4, 2024

Hi @vinay-gopalan would you mind merging #218 into this?

@bmaximuml
Copy link

Hi @vinay-gopalan would you mind merging #218 into this?

@tomhjp is this something you could review? Thanks

@eh-steve
Copy link
Contributor

Thanks for merging the first PR @vinay-gopalan, but I've since noticed the failing tests so I've opened #219 if you want to take a look

@vinay-gopalan vinay-gopalan requested review from a team and eh-steve July 23, 2024 19:26
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I deleted the generated file and ran make generate.

@vinay-gopalan vinay-gopalan merged commit b240a5a into main Jul 25, 2024
2 checks passed
@vinay-gopalan vinay-gopalan deleted the VAULT-26464/fix-update-resources-target branch July 25, 2024 20:29
@bmaximuml
Copy link

Thanks for merging this so quickly @vinay-gopalan. We'd love to get a new release of this plugin so we can start using it. Can you help us with this?

@bmaximuml
Copy link

Hi @vinay-gopalan, is there a plan for when the next plugin release will be created? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants