-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resource generation target #216
Conversation
Hi @vinay-gopalan would you mind merging #218 into this? |
@tomhjp is this something you could review? Thanks |
Thanks for merging the first PR @vinay-gopalan, but I've since noticed the failing tests so I've opened #219 if you want to take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I deleted the generated file and ran make generate
.
Thanks for merging this so quickly @vinay-gopalan. We'd love to get a new release of this plugin so we can start using it. Can you help us with this? |
Hi @vinay-gopalan, is there a plan for when the next plugin release will be created? Thanks |
Overview
Builds on #211 and fixes remaining broken resources.
Related Issues/Pull Requests
PR #211