Skip to content

Try removing the Full constructor #399

Open
@sjakobi

Description

@sjakobi

In my mind Full nodes should be pretty rare in the real world. The root node might be one, but at deeper levels I wouldn't expect to encounter any Full nodes.

Therefore it's unclear what benefit we get from all the dedicated code operating on this type of node.

From an earlier experiment to remove Full we have a report of perf regressions, but it's not clear which code regressed and why.

I would expect that the current Int benchmarks show regressions due to their unusually contiguous hash distribution, which I think is rather unrealistic.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions