From c26d0f20a7cca29c8526507832b218873b545d61 Mon Sep 17 00:00:00 2001 From: Falco Peijnenburg Date: Sat, 8 Jun 2024 13:05:53 +0200 Subject: [PATCH 1/6] Document GHC-21926 --- message-index/messages/GHC-21926/index.md | 9 +++++++++ .../after/Non-alphanumeric-in-package.hs | 5 +++++ .../before/Non-alphanumeric-in-package.hs | 5 +++++ .../GHC-21926/non-alphanumeric-in-package/index.md | 3 +++ .../after/Version-name-in-package.hs | 5 +++++ .../before/Version-name-in-package.hs | 5 +++++ .../GHC-21926/version-number-in-package/index.md | 3 +++ 7 files changed, 35 insertions(+) create mode 100644 message-index/messages/GHC-21926/index.md create mode 100644 message-index/messages/GHC-21926/non-alphanumeric-in-package/after/Non-alphanumeric-in-package.hs create mode 100644 message-index/messages/GHC-21926/non-alphanumeric-in-package/before/Non-alphanumeric-in-package.hs create mode 100644 message-index/messages/GHC-21926/non-alphanumeric-in-package/index.md create mode 100644 message-index/messages/GHC-21926/version-number-in-package/after/Version-name-in-package.hs create mode 100644 message-index/messages/GHC-21926/version-number-in-package/before/Version-name-in-package.hs create mode 100644 message-index/messages/GHC-21926/version-number-in-package/index.md diff --git a/message-index/messages/GHC-21926/index.md b/message-index/messages/GHC-21926/index.md new file mode 100644 index 00000000..b6a5c13c --- /dev/null +++ b/message-index/messages/GHC-21926/index.md @@ -0,0 +1,9 @@ +--- +title: Version number or non-alphanumeric character in package name +summary: Package imports may only consist of alphanumeric characters, and must omit the version +severity: error +introduced: 9.6.1 +--- + +Version number or non-alphanumeric character in package name. +The package name in this case refers to the package specified with imports after enabling the `PackageImports` language extension. diff --git a/message-index/messages/GHC-21926/non-alphanumeric-in-package/after/Non-alphanumeric-in-package.hs b/message-index/messages/GHC-21926/non-alphanumeric-in-package/after/Non-alphanumeric-in-package.hs new file mode 100644 index 00000000..bd5d4b1e --- /dev/null +++ b/message-index/messages/GHC-21926/non-alphanumeric-in-package/after/Non-alphanumeric-in-package.hs @@ -0,0 +1,5 @@ +{-# LANGUAGE PackageImports #-} + +module NonAlphanumericCharacterNameInPackage where + +import "some-existing-package" Package.With.Non.Alphanumeric.Characters diff --git a/message-index/messages/GHC-21926/non-alphanumeric-in-package/before/Non-alphanumeric-in-package.hs b/message-index/messages/GHC-21926/non-alphanumeric-in-package/before/Non-alphanumeric-in-package.hs new file mode 100644 index 00000000..852962fe --- /dev/null +++ b/message-index/messages/GHC-21926/non-alphanumeric-in-package/before/Non-alphanumeric-in-package.hs @@ -0,0 +1,5 @@ +{-# LANGUAGE PackageImports #-} + +module NonAlphanumericCharacterNameInPackage where + +import "&*$^%!@()" Package.With.Non.Alphanumeric.Characters diff --git a/message-index/messages/GHC-21926/non-alphanumeric-in-package/index.md b/message-index/messages/GHC-21926/non-alphanumeric-in-package/index.md new file mode 100644 index 00000000..a944b3d1 --- /dev/null +++ b/message-index/messages/GHC-21926/non-alphanumeric-in-package/index.md @@ -0,0 +1,3 @@ +--- +title: Non-alphanumeric characters in the package name +--- diff --git a/message-index/messages/GHC-21926/version-number-in-package/after/Version-name-in-package.hs b/message-index/messages/GHC-21926/version-number-in-package/after/Version-name-in-package.hs new file mode 100644 index 00000000..4aa38a03 --- /dev/null +++ b/message-index/messages/GHC-21926/version-number-in-package/after/Version-name-in-package.hs @@ -0,0 +1,5 @@ +{-# LANGUAGE PackageImports #-} + +module VersionNameInPackage where + +import "some-package" Package.With.Version diff --git a/message-index/messages/GHC-21926/version-number-in-package/before/Version-name-in-package.hs b/message-index/messages/GHC-21926/version-number-in-package/before/Version-name-in-package.hs new file mode 100644 index 00000000..3c375a85 --- /dev/null +++ b/message-index/messages/GHC-21926/version-number-in-package/before/Version-name-in-package.hs @@ -0,0 +1,5 @@ +{-# LANGUAGE PackageImports #-} + +module VersionNameInPackage where + +import "some-package-0.1.2.3" Package.With.Version diff --git a/message-index/messages/GHC-21926/version-number-in-package/index.md b/message-index/messages/GHC-21926/version-number-in-package/index.md new file mode 100644 index 00000000..6305c0e4 --- /dev/null +++ b/message-index/messages/GHC-21926/version-number-in-package/index.md @@ -0,0 +1,3 @@ +--- +title: Version number in package +--- From cc1d70d44a72ccd6dd8ba39252766f5e03cd122a Mon Sep 17 00:00:00 2001 From: Falco Peijnenburg Date: Sun, 9 Feb 2025 14:56:05 +0100 Subject: [PATCH 2/6] Apply suggested title change --- .../messages/GHC-21926/version-number-in-package/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/message-index/messages/GHC-21926/version-number-in-package/index.md b/message-index/messages/GHC-21926/version-number-in-package/index.md index 6305c0e4..0392b7e8 100644 --- a/message-index/messages/GHC-21926/version-number-in-package/index.md +++ b/message-index/messages/GHC-21926/version-number-in-package/index.md @@ -1,3 +1,3 @@ --- -title: Version number in package +title: Version number in package name --- From d5901c6db8604e528784823f6e9640b85a42a536 Mon Sep 17 00:00:00 2001 From: Falco Peijnenburg Date: Sun, 9 Feb 2025 14:56:21 +0100 Subject: [PATCH 3/6] Explain alphanumeric characters --- message-index/messages/GHC-21926/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/message-index/messages/GHC-21926/index.md b/message-index/messages/GHC-21926/index.md index b6a5c13c..4280428a 100644 --- a/message-index/messages/GHC-21926/index.md +++ b/message-index/messages/GHC-21926/index.md @@ -5,5 +5,5 @@ severity: error introduced: 9.6.1 --- -Version number or non-alphanumeric character in package name. +Version number or non-alphanumeric character in package name. Alphanumeric characters are letters and numbers, as defined by `Data.Char.isAlphaNum`. The package name in this case refers to the package specified with imports after enabling the `PackageImports` language extension. From 95967c6bbb0d19e476956fed0e00a85c0ec23e46 Mon Sep 17 00:00:00 2001 From: Falco Peijnenburg Date: Sun, 9 Feb 2025 15:06:57 +0100 Subject: [PATCH 4/6] Reword the explanation of GHC-21926 --- message-index/messages/GHC-21926/index.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/message-index/messages/GHC-21926/index.md b/message-index/messages/GHC-21926/index.md index 4280428a..05493d6c 100644 --- a/message-index/messages/GHC-21926/index.md +++ b/message-index/messages/GHC-21926/index.md @@ -5,5 +5,6 @@ severity: error introduced: 9.6.1 --- -Version number or non-alphanumeric character in package name. Alphanumeric characters are letters and numbers, as defined by `Data.Char.isAlphaNum`. -The package name in this case refers to the package specified with imports after enabling the `PackageImports` language extension. +Version number or non-alphanumeric character in the package. Alphanumeric characters are letters and numbers, as defined by `Data.Char.isAlphaNum`. +Note that you will also see this error if the package name consists only of digits. +The package name in this case refers to the one mentioned in an import when using the `PackageImports` language extension. From d4069320e905c0357aa11ff8cb36cd07eb8b58b8 Mon Sep 17 00:00:00 2001 From: Falco Peijnenburg Date: Sun, 9 Feb 2025 15:12:33 +0100 Subject: [PATCH 5/6] Add full stops and extension to GHC-21926 --- message-index/messages/GHC-21926/index.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/message-index/messages/GHC-21926/index.md b/message-index/messages/GHC-21926/index.md index 05493d6c..bf5b7abd 100644 --- a/message-index/messages/GHC-21926/index.md +++ b/message-index/messages/GHC-21926/index.md @@ -1,8 +1,9 @@ --- title: Version number or non-alphanumeric character in package name -summary: Package imports may only consist of alphanumeric characters, and must omit the version +summary: Package imports may only consist of alphanumeric characters, and must omit the version. severity: error introduced: 9.6.1 +extension: PackageImports --- Version number or non-alphanumeric character in the package. Alphanumeric characters are letters and numbers, as defined by `Data.Char.isAlphaNum`. From f1fde5c6cebe9d594a071d4d00e47c0351c6c5c3 Mon Sep 17 00:00:00 2001 From: Falco Peijnenburg Date: Fri, 21 Feb 2025 21:40:17 +0100 Subject: [PATCH 6/6] Add suggested nuance --- message-index/messages/GHC-21926/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/message-index/messages/GHC-21926/index.md b/message-index/messages/GHC-21926/index.md index bf5b7abd..cf7b2f5b 100644 --- a/message-index/messages/GHC-21926/index.md +++ b/message-index/messages/GHC-21926/index.md @@ -6,6 +6,6 @@ introduced: 9.6.1 extension: PackageImports --- -Version number or non-alphanumeric character in the package. Alphanumeric characters are letters and numbers, as defined by `Data.Char.isAlphaNum`. +Version number or non-alphanumeric character in the package. Each of dash-separated components of package name must consist of alphanumeric characters (as defined by `Data.Char.isAlphaNum`), at least one of which is not a digit. Note that you will also see this error if the package name consists only of digits. The package name in this case refers to the one mentioned in an import when using the `PackageImports` language extension.