[DT-2731] Enables pagination support#4
Merged
Conversation
Add offset() method to _SqlQuery for skip-based pagination. The offset is preserved through query chaining (where, order_by, limit, group_by, index_by) and works with joins. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
alexhermida
approved these changes
May 28, 2026
Member
alexhermida
left a comment
alexhermida
left a comment
There was a problem hiding this comment.
Looks great and simple! nothing to say
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for SQL
OFFSETin the SQLAlchemy integration, allowing for more flexible pagination and query slicing. It also adds a new documentation file,CLAUDE.md, which provides guidance for contributors and an overview of the repository's architecture and usage patterns.SQLAlchemy Integration Enhancements:
offsetparameter in SQL queries, including:offsetargument to the_SqlQueryclass and all relevant methods (e.g.,limit,order_by,group_by,where,index_by) to propagate the offset value through query construction. [1] [2] [3] [4] [5] [6] [7]offsetmethod on_SqlQueryto allow chaining and setting the offset value.resolve_sql_queryto accept and apply theoffsetvalue when building SQLAlchemy queries. [1] [2] [3] [4]Documentation Improvements:
CLAUDE.mdto provide setup instructions, development commands, an architecture overview, module structure, and key usage patterns for contributors and Claude Code.These changes improve the flexibility and usability of the SQLAlchemy integration and make the repository more accessible to new contributors.