Skip to content
This repository was archived by the owner on Jul 30, 2024. It is now read-only.

Commit 82e88ef

Browse files
committed
Legacy version
chore: Bump version chore: Remove console calls fix: Number fields validation chore: Bump version (cherry picked from commit 64f3fbe) feat: Add onChange fix: Validator error_message never issue + export all validator types chore: Build as CJS also chore: Fix peer deps versions refactor: Adapt the library to be used with legacy Flamingo chore: Set legacy package name
1 parent b2fca74 commit 82e88ef

File tree

11 files changed

+127
-73
lines changed

11 files changed

+127
-73
lines changed

package.json

+8-8
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
"devDependencies": {
1717
"@babel/core": "7.12.13",
1818
"@babel/preset-typescript": "7.12.13",
19-
"@heetch/flamingo-react": "^5.2.0",
19+
"@heetch/flamingo-react": "^4.1.3",
2020
"@nrwl/cli": "15.2.1",
2121
"@nrwl/eslint-plugin-nx": "15.2.1",
2222
"@nrwl/jest": "15.2.1",
@@ -38,9 +38,9 @@
3838
"@svgr/webpack": "^6.4.0",
3939
"@testing-library/react": "13.4.0",
4040
"@types/jest": "28.1.1",
41-
"@types/node": "18.7.18",
42-
"@types/react": "18.0.20",
43-
"@types/react-dom": "18.0.6",
41+
"@types/node": "16.11.68",
42+
"@types/react": "17.0.39",
43+
"@types/react-dom": "17.0.17",
4444
"@types/react-is": "17.0.3",
4545
"@types/styled-components": "5.1.26",
4646
"@typescript-eslint/eslint-plugin": "5.40.0",
@@ -60,7 +60,7 @@
6060
"jest-environment-jsdom": "28.1.1",
6161
"nx": "15.2.1",
6262
"prettier": "^2.6.2",
63-
"react-test-renderer": "18.2.0",
63+
"react-test-renderer": "17.0.2",
6464
"rollup-plugin-terser": "^7.0.2",
6565
"styled-components": "^5.1.0",
6666
"ts-jest": "28.0.5",
@@ -81,9 +81,9 @@
8181
"packageManager": "[email protected]",
8282
"dependencies": {
8383
"core-js": "^3.6.5",
84-
"react": "18.2.0",
85-
"react-dom": "18.2.0",
86-
"react-is": "18.2.0",
84+
"react": "17.0.2",
85+
"react-dom": "17.0.2",
86+
"react-is": "17.0.2",
8787
"regenerator-runtime": "0.13.7",
8888
"tslib": "^2.3.0"
8989
}

packages/react-forms/package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
{
2-
"name": "@heetch/react-forms",
3-
"version": "1.2.1",
2+
"name": "@heetch/react-forms-legacy",
3+
"version": "1.2.2",
44
"license": "MIT",
55
"author": "Heetch",
66
"devDependencies": {
77
"@react-hook/window-size": "^3.1.1",
88
"react-hook-form": "^7.35.0"
99
},
1010
"peerDependencies": {
11-
"@heetch/flamingo-react": "^5.2.0",
11+
"@heetch/flamingo-react": "^4.1.3",
1212
"@react-hook/window-size": "^3.1.1",
13-
"react": "18.2.0",
14-
"react-dom": "18.2.0",
13+
"react": "17.0.2",
14+
"react-dom": "17.0.2",
1515
"react-hook-form": "^7.35.0"
1616
}
1717
}

packages/react-forms/src/lib/form-field-date-renderer/form-field-date-renderer.stories.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ Helper.args = {
7171
export const IconColor = Template.bind({});
7272
IconColor.args = {
7373
field: base,
74-
options: { iconColor: flamingo.color_v3.brand.pink.shade1 },
74+
options: { iconColor: flamingo.color.brand.primary },
7575
};
7676

7777
export const DateTime = Template.bind({});

packages/react-forms/src/lib/form-field-date-renderer/form-field-date-renderer.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ export function FormFieldDateRenderer({
5959
const errorHelper = fieldState?.error?.message;
6060

6161
const iconColor = props.invalid
62-
? flamingo.color_v3.feedback.error
62+
? flamingo.color.element.error
6363
: options?.iconColor;
6464

6565
type MinMaxValidator = Exclude<

packages/react-forms/src/lib/form-field-file-renderer/form-field-file-renderer.module.scss

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
margin: 0;
99
padding-left: 0;
1010
padding-right: 0;
11-
color: var(--f-color-type-light);
11+
color: var(--f-color-element--secondary);
1212

1313
> span {
1414
font-weight: 500;

packages/react-forms/src/lib/form-field-file-renderer/form-field-file-renderer.tsx

+5-3
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ export function FormFieldFileRenderer({
7070
<UiText
7171
key={file.name}
7272
variant="subContent"
73-
textColor={flamingo.color_v3.type.default}
73+
textColor={flamingo.color.text.primary}
7474
className={[
7575
styles['FileItem'],
7676
classNames.field.file.item,
@@ -101,12 +101,14 @@ export function FormFieldFileRenderer({
101101
/>
102102
{showAddButton && (
103103
<Button
104-
variant="text"
104+
variant="minimal"
105105
onClick={() => fileInputRef.current?.click()}
106106
className={classNames.field.file.add_button}
107107
>
108+
&nbsp;
108109
<Icon icon="IconPlus" size="s" />
109-
{placeholder}
110+
{placeholder ? <>{placeholder}&nbsp;</> : ''}
111+
&nbsp;
110112
</Button>
111113
)}
112114
</div>

packages/react-forms/src/lib/form-field-number-renderer/form-field-number-renderer.stories.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ _tests.play = async () => {
103103
selector: 'input',
104104
});
105105
await userEvent.type(input, '1.5', { delay: 50 });
106-
expect(input).not.toHaveStyle({ color: '#cd2703' });
106+
expect(input).not.toHaveStyle({ color: '#e4566f' });
107107
await userEvent.clear(input);
108-
expect(input).not.toHaveStyle({ color: '#cd2703' });
108+
expect(input).not.toHaveStyle({ color: '#e4566f' });
109109
};

packages/react-forms/src/lib/form-field-number-renderer/form-field-number-renderer.tsx

+5-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { ChangeEvent, useState } from 'react';
22
import { Controller, FieldValues } from 'react-hook-form';
3-
import { InputField } from '@heetch/flamingo-react';
3+
import { InputField, theme as flamingo } from '@heetch/flamingo-react';
44
import { FormFieldRendererProps } from '../../types/renderer';
55
import { FormFieldNumber } from '../../types/fields';
66
import { buildValidationRules, classNames, isRequired } from '../../utils';
@@ -98,6 +98,8 @@ function NumberFieldRenderer({
9898
| undefined
9999
)?.parameter;
100100

101+
const invalid = !!fieldState?.error;
102+
101103
const props = {
102104
...fieldProps,
103105
onChange,
@@ -106,7 +108,8 @@ function NumberFieldRenderer({
106108
label,
107109
placeholder,
108110
helper: fieldState?.error ? fieldState.error.message : field.helper,
109-
invalid: !!fieldState?.error,
111+
invalid,
112+
textColor: invalid ? flamingo.color.element.error : undefined,
110113
type: 'number',
111114
min,
112115
max,

packages/react-forms/src/lib/form-field-string-renderer/form-field-string-renderer.tsx

+10-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
import { FormFieldRendererProps } from '../../types/renderer';
22
import { FormFieldString } from '../../types/fields';
33
import { Controller } from 'react-hook-form';
4-
import { InputField, SelectField, TextareaField } from '@heetch/flamingo-react';
4+
import {
5+
InputField,
6+
SelectField,
7+
TextareaField,
8+
theme as flamingo,
9+
} from '@heetch/flamingo-react';
510
import { buildValidationRules, classNames, isRequired } from '../../utils';
611

712
export function FormFieldStringRenderer({
@@ -29,14 +34,17 @@ export function FormFieldStringRenderer({
2934
label = undefined;
3035
}
3136

37+
const invalid = !!fieldState?.error;
38+
3239
const props = {
3340
...fieldProps,
3441
id: fieldProps.name,
3542
value: fieldProps.value !== undefined ? fieldProps.value : '',
3643
label,
3744
placeholder,
3845
helper: fieldState?.error ? fieldState.error.message : field.helper,
39-
invalid: !!fieldState?.error,
46+
invalid,
47+
textColor: invalid ? flamingo.color.element.error : undefined,
4048
disabled: field.disabled,
4149
};
4250

packages/react-forms/src/types/renderer.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import { FormField } from './fields';
22
import { Control, FieldValues, UseFormSetValue } from 'react-hook-form';
3-
import { DefaultTexts, FormOptions } from '@heetch/react-forms';
3+
import { DefaultTexts, FormOptions } from './forms';
44

55
export type FormFieldRendererProps<T extends FormField> = {
66
field: T;

0 commit comments

Comments
 (0)