Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All UnknownTransaction fields should be camelCased #280

Open
danielcolinjames opened this issue Feb 2, 2022 · 0 comments
Open

All UnknownTransaction fields should be camelCased #280

danielcolinjames opened this issue Feb 2, 2022 · 0 comments

Comments

@danielcolinjames
Copy link
Contributor

I think we should make UnknownTransactions have all camelCased fields so we can better prepare for when the type is fully supported in helium-js, and avoid re-writing any frontend code (e.g. challenger_owner will eventually have to be updated to challengerOwner)

there are some examples of us doing this with camelCaseKeys() in helium-js

and this may be a separate issue, and I haven't thought it all the way through, but we could probably also convert some or all transactions to automatically return all camelCased keys so that when a new field gets added to hotspot for example, it'll automatically start showing up instead of needing to be manually added to the hotspot definition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant