You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There appears to be a typo in the _strip_string function of the math_equivalence.py file, where an unnecessary escape character is used with the percent sign. The code uses string.replace("\%", "") when it seems to me that string.replace("%", "") was intended. I'm not 100% certain whether this behavior is unintentional but currently is_equiv("50%", "50") == False. The current code also throws a warning for python 3.11.
Everything in the data should be correctly normalized since they all seem to be formatted like 50\%.
The only difference due to this is when the model predicts 50% instead of 50 or 50\% because is_equiv("50\\%", "50%") == False. There are 51 % signs in the test set(~1%), and the results are only impacted if the model acts in a certain way.
Description
There appears to be a typo in the
_strip_string
function of themath_equivalence.py
file, where an unnecessary escape character is used with the percent sign. The code usesstring.replace("\%", "")
when it seems to me thatstring.replace("%", "")
was intended. I'm not 100% certain whether this behavior is unintentional but currentlyis_equiv("50%", "50") == False
. The current code also throws a warning for python 3.11.math/modeling/math_equivalence.py
Line 104 in 357963a
Suggestion
The text was updated successfully, but these errors were encountered: