Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bridge error handling #275

Open
hensm opened this issue Feb 26, 2023 · 0 comments
Open

Improve bridge error handling #275

hensm opened this issue Feb 26, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@hensm
Copy link
Owner

hensm commented Feb 26, 2023

Error handling for CastClient#connect is possibly incorrect and broken depending on how error events are emitted. Rejected promise is not handled by consumers and causes the bridge to crash which can under certain conditions result in error loops when the bridge is restarted.

connect(host: string, options?: CastClientConnectOptions) {
return new Promise<void>((resolve, reject) => {
// Handle errors
this.client.on("error", reject);

@hensm hensm added bug Something isn't working good first issue Good for newcomers labels Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant