Skip to content

Conversation

@mkroening
Copy link
Member

@mkroening mkroening commented Nov 28, 2025

Extracted and extended from #2078.

Best reviewed commit by commit.

@mkroening mkroening self-assigned this Nov 28, 2025
@mkroening mkroening requested a review from fogti November 28, 2025 16:11
@mkroening mkroening marked this pull request as ready for review November 28, 2025 16:11
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Benchmark Current: 2e8e4de Previous: 888138f Performance Ratio
startup_benchmark Build Time 114.97 s 118.05 s 0.97
startup_benchmark File Size 0.91 MB 0.91 MB 1.00
Startup Time - 1 core 0.98 s (±0.03 s) 0.99 s (±0.03 s) 0.98
Startup Time - 2 cores 0.98 s (±0.03 s) 0.99 s (±0.03 s) 0.98
Startup Time - 4 cores 1.01 s (±0.02 s) 1.00 s (±0.03 s) 1.01
multithreaded_benchmark Build Time 115.71 s 115.18 s 1.00
multithreaded_benchmark File Size 1.02 MB 1.02 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 94.35 % (±8.97 %) 90.15 % (±9.83 %) 1.05
Multithreaded Pi Efficiency - 4 Threads 45.61 % (±3.83 %) 45.36 % (±3.67 %) 1.01
Multithreaded Pi Efficiency - 8 Threads 25.82 % (±1.69 %) 25.88 % (±1.64 %) 1.00
micro_benchmarks Build Time 311.27 s 309.13 s 1.01
micro_benchmarks File Size 1.02 MB 1.02 MB 1.00
Scheduling time - 1 thread 193.21 ticks (±28.53 ticks) 192.36 ticks (±43.73 ticks) 1.00
Scheduling time - 2 threads 112.43 ticks (±20.43 ticks) 98.52 ticks (±18.66 ticks) 1.14
Micro - Time for syscall (getpid) 11.91 ticks (±5.47 ticks) 10.10 ticks (±4.57 ticks) 1.18
Memcpy speed - (built_in) block size 4096 57950.25 MByte/s (±41690.55 MByte/s) 50476.33 MByte/s (±38071.50 MByte/s) 1.15
Memcpy speed - (built_in) block size 1048576 13401.45 MByte/s (±11069.29 MByte/s) 13220.79 MByte/s (±10939.10 MByte/s) 1.01
Memcpy speed - (built_in) block size 16777216 8938.14 MByte/s (±7180.03 MByte/s) 9179.23 MByte/s (±7380.62 MByte/s) 0.97
Memset speed - (built_in) block size 4096 56949.40 MByte/s (±41384.54 MByte/s) 50871.67 MByte/s (±38300.90 MByte/s) 1.12
Memset speed - (built_in) block size 1048576 13776.56 MByte/s (±11312.38 MByte/s) 13604.75 MByte/s (±11172.65 MByte/s) 1.01
Memset speed - (built_in) block size 16777216 9107.25 MByte/s (±7267.89 MByte/s) 9420.72 MByte/s (±7531.44 MByte/s) 0.97
Memcpy speed - (rust) block size 4096 51891.97 MByte/s (±37782.93 MByte/s) 51927.14 MByte/s (±37738.23 MByte/s) 1.00
Memcpy speed - (rust) block size 1048576 13735.58 MByte/s (±11431.45 MByte/s) 13892.67 MByte/s (±11478.50 MByte/s) 0.99
Memcpy speed - (rust) block size 16777216 9180.04 MByte/s (±7409.38 MByte/s) 9058.53 MByte/s (±7264.87 MByte/s) 1.01
Memset speed - (rust) block size 4096 52709.21 MByte/s (±38334.08 MByte/s) 52500.48 MByte/s (±38096.76 MByte/s) 1.00
Memset speed - (rust) block size 1048576 13978.44 MByte/s (±11547.43 MByte/s) 14186.15 MByte/s (±11639.43 MByte/s) 0.99
Memset speed - (rust) block size 16777216 9355.08 MByte/s (±7498.54 MByte/s) 9284.18 MByte/s (±7402.49 MByte/s) 1.01
alloc_benchmarks Build Time 306.93 s 306.72 s 1.00
alloc_benchmarks File Size 0.98 MB 0.98 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 30393.11 Ticks (±1673.06 Ticks) 30379.57 Ticks (±1264.46 Ticks) 1.00
Allocations - Average Allocation time (no fail) 30393.11 Ticks (±1673.06 Ticks) 30379.57 Ticks (±1264.46 Ticks) 1.00
Allocations - Average Deallocation time 3420.62 Ticks (±1898.31 Ticks) 3176.27 Ticks (±1185.47 Ticks) 1.08
mutex_benchmark Build Time 305.58 s 305.15 s 1.00
mutex_benchmark File Size 1.02 MB 1.02 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 39.80 ns (±4.31 ns) 38.38 ns (±4.82 ns) 1.04
Mutex Stress Test Average Time per Iteration - 2 Threads 32.64 ns (±3.66 ns) 31.76 ns (±3.33 ns) 1.03

This comment was automatically generated by workflow using github-action-benchmark.

@mkroening mkroening added this pull request to the merge queue Nov 29, 2025
@mkroening mkroening removed this pull request from the merge queue due to a manual request Nov 29, 2025
@mkroening mkroening changed the title refactor(mem/fs): simplify lseek fix(mem/fs): improve lseek errors Nov 29, 2025
@mkroening mkroening added this pull request to the merge queue Nov 29, 2025
Merged via the queue into main with commit 21f1bb3 Nov 29, 2025
18 of 19 checks passed
@mkroening mkroening deleted the fs-mem-lseek branch December 1, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants