-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Why package.json and app.json? #72
Comments
App.json is used by the Heroku Button for deployment on Heroku, although in this case, there's little useful content in it and yes, it's mostly redundant with package.json. I think the only content that's used is the icon. |
🙈 |
|
I guess it's possible, but the Heroku Button needs to work for Rails, Java, and other apps, which don't generally have a package.json file. We did debate internally whether we should just use package.json instead of a separate file, but the separate app.json won. |
Not that it matters much, but the above-mentioned package.json reference is not about the package.json used by node and npm. That one is here: https://docs.npmjs.com/files/package.json We have a related discussion going on the npm website repo about logos/icons: https://github.com/npm/newww/issues/291 |
Thanks @zeke for correcting the reference and thanks @markpundsack for the background. Just my two cents but seems like those other apps (Rails, Java, etc.) are still going to be adding a new file to their project, so why not call it package.json? I think the conceptual burden is understanding that there is now a JSON file in the root that profiles the application. Calling it app.json instead of package.json doesn't make it any more obvious than just looking at the contents. It's a minor issue, but I'm just averse to having to update information in two places and having an extra file in the project root. Seeing a dozen process/environment/task files in the root triggers an intense jaw clench. |
I know how you feel. I campaigned for Hopefully you don't have a |
The app.json file is needed by Heroku for using the 'Deploy to Heroku' Button. - Link: https://devcenter.heroku.com/articles/heroku-button - Issue: heroku/node-js-sample#72
The app.json file is needed by Heroku for using the 'Deploy to Heroku' Button. - Link: https://devcenter.heroku.com/articles/heroku-button - Issue: heroku/node-js-sample#72
The app.json file is needed by Heroku for using the 'Deploy to Heroku' Button. - Link: https://devcenter.heroku.com/articles/heroku-button - Issue: heroku/node-js-sample#72
These two files have significant content overlap. What is the reason or purpose for having both?
The text was updated successfully, but these errors were encountered: