add file upload method #26
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(again based on #24)
This PR adds the ability to use the file upload endpoint directly through
Moodleinstances:Since file uploads go through a separate endpoint (
/webservice/upload.phpinstead of/webservice/rest/server.php), I added a method to theMdlbase class, and an exception in case the URL can't be determined (for very nonstandard Moodle setups). The user facing API mirrors the other modules, with anUploadclass extendingBaseMoodle. Since there are no other methods, I used__call__(). If you don't agree with any of these decisions, I'd be happy to adjust the code, or accept your adjustments.I also added a test case to make sure the code works.