refactor(model): add Code model for include_code tag #5633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to testgit clone -b fix/code https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test |
5 tasks
|
I'm not sure the files in code_dir need to be written to the public folder |
Pull Request Test Coverage Report for Build 14840515565Details
💛 - Coveralls |
yoshinorin
reviewed
May 5, 2025
| const Code = new warehouse.Schema<CodeSchema>({ | ||
| _id: { type: String, required: true }, | ||
| path: { type: String, required: true }, | ||
| slug: { type: String, required: true }, |
There was a problem hiding this comment.
Because the same value is already set in path, I don't think slug is necessary. Though the difference may be slight, reducing the elements in Schema<CodeSchema> should have a positive effect on performance.
However, if we remove the slug, it could potentially be a breaking change since there may be users referencing it in custom scripts or etc..., so it might require an announcement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
try to fix #5479 and #5486
ref #5479 (comment)
Since the current model doesn't satisfy
include_code, I experimentally added the Code ModelScreenshots
Pull request tasks