Skip to content

Commit bd93ae9

Browse files
committed
test(producer): address review feedback on parallel capture test
- Add fixture to shard-5 in regression.yml so CI actually runs it - Reframe description: multi-worker path coverage (frame distribution, reorder buffer, per-worker browser lifecycle), not GPU-specific crash guard — SwiftShader CI can't reproduce the hardware compositor race - Remove dead @Keyframes count-up (content doesn't apply to div) - Remove unused CSS animation reference on .counter - Regenerate golden baseline with cleaned-up HTML
1 parent 8f888aa commit bd93ae9

5 files changed

Lines changed: 4 additions & 24 deletions

File tree

.github/workflows/regression.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ jobs:
7373
- shard: shard-4
7474
args: "style-16-prod style-9-prod style-17-prod iframe-render-compat variables-prod mp4-h265-sdr"
7575
- shard: shard-5
76-
args: "style-4-prod style-11-prod style-2-prod animejs-adapter typegpu-adapter"
76+
args: "style-4-prod style-11-prod style-2-prod animejs-adapter typegpu-adapter parallel-capture-regression"
7777
- shard: shard-6
7878
args: "overlay-montage-prod style-12-prod chat missing-host-comp-id png-sequence"
7979
- shard: shard-7

packages/producer/tests/parallel-capture-regression/meta.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "parallel-capture-regression",
3-
"description": "Regression test for multi-worker parallel capture. Exercises the browser-per-worker code path that prevents BeginFrame compositor races. Must render with workers > 1 to be meaningful.",
3+
"description": "Multi-worker parallel capture path coverage. Exercises frame distribution, reorder buffer, and per-worker browser lifecycle at workers > 1. Guards against regressions in executeParallelCapture and the streaming encoder's ordered-write path. Note: the GPU-specific BeginFrame compositor race (#1087) only reproduces on hardware-GPU hosts, not in SwiftShader CI.",
44
"tags": ["regression", "parallel", "render-compat"],
55
"minPsnr": 30,
66
"maxFrameFailures": 0,

packages/producer/tests/parallel-capture-regression/output/compiled.html

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@
5555
background: linear-gradient(135deg, #58a6ff, #bc8cff);
5656
-webkit-background-clip: text;
5757
-webkit-text-fill-color: transparent;
58-
animation: count-up 5s steps(5, end) forwards;
5958
}
6059

6160
.pulse-ring {
@@ -81,15 +80,6 @@
8180
50% { opacity: 0.8; transform: translate(-50%, -50%) scale(1.15); }
8281
}
8382

84-
@keyframes count-up {
85-
0% { content: "0"; }
86-
20% { content: "1"; }
87-
40% { content: "2"; }
88-
60% { content: "3"; }
89-
80% { content: "4"; }
90-
100% { content: "5"; }
91-
}
92-
9383
.stripe-bg {
9484
position: absolute;
9585
inset: 0;
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
version https://git-lfs.github.com/spec/v1
2-
oid sha256:b33f5ba567a8df551c85b2008482400c9ca10e402379b22cd35b1722148c1046
3-
size 1185810
2+
oid sha256:f717cf22344ed7c4792e22db0dd9340dd9b845ce04ced0b60410b58344855ca0
3+
size 1186833

packages/producer/tests/parallel-capture-regression/src/index.html

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@
5555
background: linear-gradient(135deg, #58a6ff, #bc8cff);
5656
-webkit-background-clip: text;
5757
-webkit-text-fill-color: transparent;
58-
animation: count-up 5s steps(5, end) forwards;
5958
}
6059

6160
.pulse-ring {
@@ -81,15 +80,6 @@
8180
50% { opacity: 0.8; transform: translate(-50%, -50%) scale(1.15); }
8281
}
8382

84-
@keyframes count-up {
85-
0% { content: "0"; }
86-
20% { content: "1"; }
87-
40% { content: "2"; }
88-
60% { content: "3"; }
89-
80% { content: "4"; }
90-
100% { content: "5"; }
91-
}
92-
9383
.stripe-bg {
9484
position: absolute;
9585
inset: 0;

0 commit comments

Comments
 (0)