Skip to content
This repository was archived by the owner on Aug 1, 2023. It is now read-only.

Commit 61abf65

Browse files
committed
Codegen router files in strict mode, update minimum version
Minimum HHVM version is updated as the new hack-codegen requires a newer hhvm, for coeffects support.
1 parent f9ee2df commit 61abf65

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/build-and-test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
matrix:
1414
os: [ ubuntu ]
1515
hhvm:
16-
- '4.62'
16+
- '4.93'
1717
- latest
1818
- nightly
1919
runs-on: ${{matrix.os}}-latest

composer.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44
"keywords": ["hack", "router", "routing", "hhvm"],
55
"homepage": "https://github.com/hhvm/hack-router-codegen",
66
"require": {
7-
"hhvm": "^4.25",
7+
"hhvm": "^4.93",
88
"facebook/hack-router": "^0.19",
99
"facebook/hack-http-request-response-interfaces": "^0.2|^0.3",
10-
"facebook/hack-codegen": "^4.1.0",
10+
"facebook/hack-codegen": "^4.5.0",
1111
"facebook/definition-finder": "^2.7",
1212
"hhvm/type-assert": "^3.0|^4.0"
1313
},

src/RouterCLILookupCodegenBuilder.hack

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ final class RouterCLILookupCodegenBuilder {
7070
$file = $this->cg->codegenFile($path)
7171
->setDoClobber($this->discardChanges)
7272
->setShebangLine('#!/usr/bin/env hhvm')
73-
->setFileType(CodegenFileType::HACK_PARTIAL)
73+
->setFileType(CodegenFileType::HACK_STRICT)
7474
->setGeneratedFrom($this->generatedFrom)
7575
->addClass($this->getCodegenClass($router_classname, $utility_classname))
7676
->addFunction(

0 commit comments

Comments
 (0)