Add a test for CLI when an exception is thrown

Author: Atry

test-data/hhast-lint.json

@@ -1,5 +1,11 @@
 {
-  "roots": [],
+  "roots": [ "." ],
+  "extraLinters": [
+    "Facebook\\HHAST\\Tests\\ValidConfigForLinter",
+    "Facebook\\HHAST\\Tests\\InvalidConfigForLinter",
+    "Facebook\\HHAST\\FinalOrAbstractClassLinter",
+    "Facebook\\HHAST\\Tests\\ConfigTypeIsNotSupportedByTypeAssertLinter"
+  ],
   "linterConfigs": {
     "Facebook\\HHAST\\Tests\\ValidConfigForLinter": {
       "the answer": 42,

tests/LinterConfigTest.hack

@@ -9,18 +9,20 @@
 
 namespace Facebook\HHAST\Tests;
 
-use type Facebook\HackTest\HackTest;
 use function Facebook\FBExpect\expect;
 use type Facebook\HHAST\{
+  LinterCLITestTrait,
   PreferRequireOnceLinter,
   SingleRuleLintError,
   SingleRuleLinter,
+  TestCase,
 };
 use type Facebook\HHAST\__Private\LintRunConfig;
 
 abstract class EmptyBaseLinter extends SingleRuleLinter {
   <<__Override>>
-  final public async function getLintErrorsAsync(): Awaitable<vec<SingleRuleLintError>> {
+  final public async function getLintErrorsAsync(
+  ): Awaitable<vec<SingleRuleLintError>> {
     return vec[];
   }
   final public function getConfigPublic(): ?this::TConfig {
@@ -54,9 +56,13 @@ final class ConfigTypeIsNotSupportedByTypeAssertLinter extends EmptyBaseLinter {
   const type TConfig = shape('impossible' => vec<nothing>);
 }
 
-final class LinterConfigTest extends HackTest {
+final class LinterConfigTest extends TestCase {
+  use LinterCLITestTrait;
+
+  const string TEST_DIRECTORY = __DIR__.'/../test-data';
+
   private static function getLintRunConfig(): LintRunConfig {
-    return LintRunConfig::getForPath(__DIR__.'/../test-data');
+    return LintRunConfig::getForPath(self::TEST_DIRECTORY);
   }
 
   public function testValidConfigForLinter(): void {
@@ -87,6 +93,26 @@ final class LinterConfigTest extends HackTest {
     )->toThrow(\Exception::class, 'is not of the correct type');
   }
 
+  public async function testInvalidConfigForCLI(): Awaitable<void> {
+    list($cli, $_, $stdout, $stderr) =
+      $this->getCLI('--config-file', self::TEST_DIRECTORY.'/hhast-lint.json', self::TEST_DIRECTORY);
+    $exit_code = await $cli->mainAsync();
+    expect($stderr->getBuffer())->toContainSubstring(
+      'A linter threw an exception:',
+    );
+    expect($stderr->getBuffer())->toContainSubstring(
+      'Linter: Facebook\HHAST\Tests\InvalidConfigForLinter',
+    );
+    expect($stderr->getBuffer())->toMatchRegExp(
+      re'#File\\: .*/test-data/unparsable_php_file\\.php#',
+    );
+    expect($stderr->getBuffer())->toContainSubstring(
+      'Message: Configuration for Facebook\HHAST\Tests\InvalidConfigForLinter is not of the correct type. See previous exception:',
+    );
+    expect($exit_code)->toBeSame(2);
+    expect($stdout->getBuffer())->toBeEmpty();
+  }
+
   public function testLinterWithoutATConfigAndNoConfigSupplied(): void {
     $lrc = static::getLintRunConfig();