-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add missing is_on property to RemoteEntity #2843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughUpdated the Remote entity documentation table: adjusted header formatting, added a new Changes
Sequence Diagram(s)No sequence diagrams — documentation-only change. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting 📒 Files selected for processing (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/core/entity/remote.md (1)
19-21: Minor formatting inconsistency: Default value representation.Line 21 uses backticks around
Noneto format it as code, but the existing default values on lines 22-23 are not backticked. For consistency, consider aligning the formatting across all rows.Apply this diff to standardize the formatting:
- | is_on | boolean | `None` | If the device is currently on or off. | - | current_activity | str | None | Return the list of available activities | - | activity_list | list | None | Return the list of available activities | + | is_on | boolean | None | If the device is currently on or off. | + | current_activity | str | None | Return the current active activity | + | activity_list | list | None | Return the list of available activities |(Note: I also aligned the description for
current_activitywhich appears to have been incorrectly copied fromactivity_list.)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
docs/core/entity/remote.md(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Redirect rules - developers-home-assistant
- GitHub Check: Header rules - developers-home-assistant
- GitHub Check: Pages changed - developers-home-assistant
🔇 Additional comments (1)
docs/core/entity/remote.md (1)
19-21: Documentation addition looks good.The change correctly documents the
is_onproperty as an inherited member from ToggleEntity. The property type, default, and description are accurate and align with the PR objectives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
docs/core/entity/remote.md(1 hunks)
abmantis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Proposed change
RemoteEntity extends
ToggleEntity, so it also inheritis_onproperty.Type of change
Checklist
Additional information
Summary by CodeRabbit