Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Class support #42

Open
pinzonjulian opened this issue Jul 31, 2024 · 1 comment
Open

Data Class support #42

pinzonjulian opened this issue Jul 31, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@pinzonjulian
Copy link

Hey!

I've added support for Ruby's Data class and seems like something to add to UniversalID natively. Here's my implementation:

UniversalID::MessagePackFactory.register(
  type: Data,
  packer: -> (model, packer) {
    packer.write(model.class)
    packer.write(model.to_h)
  },
  unpacker: -> (unpacker) {
    model_name = unpacker.read
    model_name.new(**unpacker.read)
  }
)
@hopsoft
Copy link
Owner

hopsoft commented Dec 17, 2024

This is a great addition. Would you mind submitting a PR?

@hopsoft hopsoft added the enhancement New feature or request label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants