Skip to content

Re-exporting sl- components at hot- results in events not triggering #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spwoodcock opened this issue Feb 5, 2025 · 1 comment
Labels
bug Something isn't working priority:high

Comments

@spwoodcock
Copy link
Member

spwoodcock commented Feb 5, 2025

Describe the bug

  • Have a hunch that some of the components rely on accessing sl-xxx in some events.
  • A good example of a combination of components is: https://shoelace.style/components/dropdown#getting-the-selected-item
  • Here when we have hot-dropdown, selecting an element doesn't seem to do anything.
  • I am assuming that if it was sl-dropdown this would work.

To Reproduce

  • Create a dropdown as above.

Expected behavior

  • I'm starting to think we should probably not re-export the low level components.
  • Keep a mix of sl-xxx for those, plus hot-xxx for the composite components we create.
  • This will mean we need to update the CSS vars too.
@spwoodcock spwoodcock added bug Something isn't working priority:high labels Feb 5, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Shared UI Feb 5, 2025
@emi420
Copy link
Collaborator

emi420 commented Feb 6, 2025

I agree that we should not re-export the Shoelace components.

We should keep the theme for Shoelace, there's not need of changing anything there because it's using the 'sl-' prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:high
Projects
Status: Backlog
Development

No branches or pull requests

2 participants