-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If a user is not added to a facility, the orders should not be visible to the user. #235
Comments
d@adityasharma7 what is the solution her, I remember that we discussed this limitation before. |
We could disallow the user to log in if not associated with any facility role. The issue is that we are getting facilities from the user profile API and the admin user might not be able to log in. |
@Dhiraj1405 Please verify, as we have added support to login into the app to only those users that are associated with some facility. |
Tested, working as expected. |
The user can log in to the app without being associated with any facility. Therefore, the issue is being reopened. |
Fixed: restricting user to login to app without any facility associated (#235)
Here is what I tested, I think issue is still happening. Tested on Dev OMS |
@dt2patel sir, Did you tested this on dev version of app? Since this is not in release so far, hence not in UAT or Prod. |
Sorry forgot to add link. Tested in BOPIS dev |
I think here the issue is in the users app, as the user used for testing is associated with a facility. |
ok, let me fix data manually, check and then create issue in users app |
Issue verified and working fine in release v3.4.0 Hence, closing this ticket. |
What is the motivation for adding/enhancing this feature?
If an user is not added to any facility, currently they can see orders for all facilities.
What are the acceptance criteria?
If a user is not added to any facilities, no orders should be visible to the user.
Can you complete this feature request by yourself?
Additional information
The text was updated successfully, but these errors were encountered: