Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If a user is not added to a facility, the orders should not be visible to the user. #235

Closed
3 tasks
appurvajain opened this issue May 11, 2023 · 11 comments
Closed
3 tasks
Assignees
Labels
bug Something isn't working release-v3.4.0

Comments

@appurvajain
Copy link
Contributor

What is the motivation for adding/enhancing this feature?

If an user is not added to any facility, currently they can see orders for all facilities.

What are the acceptance criteria?

If a user is not added to any facilities, no orders should be visible to the user.

  • ...

Can you complete this feature request by yourself?

  • YES
  • NO

Additional information

@dt2patel dt2patel moved this to 📋 Backlog in Digital Experience Platform Jun 7, 2023
@dt2patel dt2patel added the bug Something isn't working label Jun 7, 2023
@dt2patel
Copy link
Contributor

d@adityasharma7 what is the solution her, I remember that we discussed this limitation before.

@adityasharma7
Copy link
Contributor

adityasharma7 commented Jun 20, 2023

We could disallow the user to log in if not associated with any facility role. The issue is that we are getting facilities from the user profile API and the admin user might not be able to log in.

@dt2patel dt2patel assigned alsoK2maan and unassigned adityasharma7 Jul 5, 2023
@ymaheshwari1
Copy link
Contributor

@Dhiraj1405 Please verify, as we have added support to login into the app to only those users that are associated with some facility.

@ymaheshwari1 ymaheshwari1 assigned Dhiraj1405 and unassigned alsoK2maan Nov 2, 2023
@ymaheshwari1 ymaheshwari1 moved this from 📋 Backlog to 👀 In review in Digital Experience Platform Nov 2, 2023
@Dhiraj1405
Copy link
Contributor

Tested, working as expected.

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Digital Experience Platform Nov 2, 2023
@priyanshee1604
Copy link
Contributor

The user can log in to the app without being associated with any facility. Therefore, the issue is being reopened.

@ymaheshwari1 ymaheshwari1 moved this from ✅ Done to 📅 Planned in Digital Experience Platform Jan 22, 2025
@amansinghbais amansinghbais moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Jan 24, 2025
amansinghbais added a commit to amansinghbais/bopis that referenced this issue Jan 24, 2025
amansinghbais added a commit to amansinghbais/bopis that referenced this issue Jan 24, 2025
@amansinghbais amansinghbais moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Jan 24, 2025
amansinghbais added a commit to amansinghbais/bopis that referenced this issue Jan 27, 2025
ymaheshwari1 added a commit that referenced this issue Jan 27, 2025
Fixed: restricting user to login to app without any facility associated (#235)
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Jan 27, 2025
@dt2patel
Copy link
Contributor

dt2patel commented Feb 4, 2025

Here is what I tested, I think issue is still happening. Tested on Dev OMS
https://jam.dev/c/58a75bc0-b99b-48f4-9382-c7207e687c39

@amansinghbais
Copy link
Contributor

@dt2patel sir,

Did you tested this on dev version of app? Since this is not in release so far, hence not in UAT or Prod.

@dt2patel
Copy link
Contributor

dt2patel commented Feb 4, 2025

Sorry forgot to add link. Tested in BOPIS dev

@ymaheshwari1
Copy link
Contributor

Sorry forgot to add link. Tested in BOPIS dev

I think here the issue is in the users app, as the user used for testing is associated with a facility.

@dt2patel
Copy link
Contributor

dt2patel commented Feb 4, 2025

ok, let me fix data manually, check and then create issue in users app

@shubham-namdeo
Copy link

Issue verified and working fine in release v3.4.0 Hence, closing this ticket.

@github-project-automation github-project-automation bot moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release-v3.4.0
Projects
Status: ✅ Done
Development

No branches or pull requests

9 participants