Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete product icon not disappearing #667

Closed
dt2patel opened this issue Feb 4, 2025 · 3 comments
Closed

Delete product icon not disappearing #667

dt2patel opened this issue Feb 4, 2025 · 3 comments
Assignees
@shubham-namdeo
Labels
bug Something isn't working

Comments

@dt2patel
Copy link
Contributor

dt2patel commented Feb 4, 2025

Current behavior

The delete product icon is not disappearing after removing a product. It has to be clicked twice

https://jam.dev/c/8238d11a-824b-4857-a0d6-5b0351bbb10d
@dt2patel dt2patel added the bug Something isn't working label Feb 4, 2025
@dt2patel dt2patel moved this from 📋 Backlog to 📅 Planned in Digital Experience Platform Feb 4, 2025
@amansinghbais
Copy link
Contributor

Also look around issue, where if a hard count already have persisted unmatched product and we delete all of them at once, leave page and comes back they still shows to us.

They should be deleted from the hard count permanently.

@priyanshee1604
Copy link
Contributor

Also look around issue, where if a hard count already have persisted unmatched product and we delete all of them at once, leave page and comes back they still shows to us.

They should be deleted from the hard count permanently.

Jam: https://jam.dev/c/ee343556-a331-4604-aff9-6d1d07d01902

@priyanshee1604 priyanshee1604 moved this from 📅 Planned to 🏗 In progress in Digital Experience Platform Feb 10, 2025
priyanshee1604 added a commit to priyanshee1604/inventory-count that referenced this issue Feb 10, 2025
@priyanshee1604
Fixed: Delete product icon not disappearing.(hotwax#667)
d1a1e0d
priyanshee1604 added a commit to priyanshee1604/inventory-count that referenced this issue Feb 10, 2025
@priyanshee1604
Fixed: Unmatched products are now permanently deleted from the hard c…
c8e7c21 
…ount when removed all at once.(hotwax#667)
priyanshee1604 added a commit to priyanshee1604/inventory-count that referenced this issue Feb 10, 2025
@priyanshee1604
Fixed: Delete product icon not disappearing.(hotwax#667)
12dd133
priyanshee1604 added a commit to priyanshee1604/inventory-count that referenced this issue Feb 10, 2025
@priyanshee1604
Fixed: Unmatched products are now permanently deleted from the hard c…
13626ca 
…ount when removed all at once.(hotwax#667)
@priyanshee1604 priyanshee1604 mentioned this issue Feb 10, 2025
Merged
1 task
@priyanshee1604 priyanshee1604 moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Feb 10, 2025
@priyanshee1604 priyanshee1604 moved this from 👀 In review to 🏗 In progress in Digital Experience Platform Feb 10, 2025
priyanshee1604 added a commit to priyanshee1604/inventory-count that referenced this issue Feb 11, 2025
@priyanshee1604
Improved: the code for Delete product icon not disappearing.(hotwax#667)
4c7ba77
priyanshee1604 added a commit to priyanshee1604/inventory-count that referenced this issue Feb 11, 2025
@priyanshee1604
Improved: Remove empty array entries from state instead of setting th…
efe28c2 
…em.(hotwax#667)
priyanshee1604 added a commit to priyanshee1604/inventory-count that referenced this issue Feb 11, 2025
@priyanshee1604
Improved: clearCurrentCountFromCachedUnmatchProducts to remove Cycle …
3dbc229 
…Count only if it exists (hotwax#667)
priyanshee1604 added a commit to priyanshee1604/inventory-count that referenced this issue Feb 11, 2025
@priyanshee1604
Improved: Indentation.(hotwax#667)
95f0671
@priyanshee1604 priyanshee1604 moved this from 🏗 In progress to 👀 In review in Digital Experience Platform Feb 11, 2025
ymaheshwari1 added a commit that referenced this issue Feb 14, 2025
@ymaheshwari1
Merge pull request #680 from priyanshee1604/#667
996e9e3 
Fixed: Delete product icon now disappears and Unmatched products are now permanently deleted from the hard count when removed all at once.
@ymaheshwari1 ymaheshwari1 moved this from 👀 In review to ⏸️ Dev complete in Digital Experience Platform Feb 14, 2025
@shubham-namdeo
Copy link

Issue verified and working fine in Dev, hence, closing the ticket.

@github-project-automation github-project-automation bot moved this from ⏸️ Dev complete to ✅ Done in Digital Experience Platform Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubham-namdeo shubham-namdeo

Labels
bug Something isn't working
Projects
Digital Experience Platform
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ravilodhi @dt2patel @amansinghbais @priyanshee1604 @shubham-namdeo