Merge pull request #4351 from jeclrsg/fix-comms-unhelpful-exception-logging

fix(comms): add more info to unhelpful exception logging

Author: GordonSmith

packages/comms/src/ecl/dfuWorkunit.ts

@@ -355,7 +355,7 @@ export class DFUWorkunit extends StateObject<UDFUWorkunitState, IDFUWorkunitStat
                 return false;
             });
             if (!wuMissing) {
-                logger.warning("Unexpected exception:  ");
+                logger.warning(`Unexpected ESP exception: ${e.message}`);
                 throw e;
             }
             return {} as FileSpray.GetDFUWorkunitResponse;

packages/comms/src/ecl/logicalFile.ts

@@ -165,7 +165,7 @@ export class LogicalFile extends StateObject<FileDetailEx, FileDetailEx> impleme
                 return false;
             });
             if (!fileMissing) {
-                logger.warning("Unexpected exception:  ");
+                logger.warning(`Unexpected ESP exception: ${e.message}`);
                 throw e;
             }
             return {} as FileDetailEx;

packages/comms/src/ecl/workunit.ts

@@ -1012,7 +1012,7 @@ export class Workunit extends StateObject<UWorkunitState, IWorkunitState> implem
                 return false;
             });
             if (!wuMissing) {
-                logger.warning("Unexpected exception:  ");
+                logger.warning(`Unexpected ESP exception: ${e.message}`);
                 throw e;
             }
             return {} as WsWorkunits.WUQueryResponse;
@@ -1054,7 +1054,7 @@ export class Workunit extends StateObject<UWorkunitState, IWorkunitState> implem
                 return false;
             });
             if (!wuMissing) {
-                logger.warning("Unexpected exception:  ");
+                logger.warning(`Unexpected ESP exception: ${e.message}`);
                 throw e;
             }
             return {} as WsWorkunits.WUInfoResponse;