Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look into all the survey APIs and provide the necessary audit fields. #334

Open
logicsandeep opened this issue May 25, 2020 · 3 comments
Open

Comments

@logicsandeep
Copy link
Contributor

Look into all the survey APIs and provide the create_date and modified date fields .

For example:
The below API does not return any audit fields like create_date and modified date . This becomes really hard to track when a submission really occurred if the effectiveDate was not populated.

GET /clientsurveysubmission

PS: Need to look into all the APIs in the survey api project and make sure we provide createDate and modifiedDate.

@suryayadavalli
Copy link
Contributor

As discussed in Friday's meeting, I will populate effective date with created date if its not explicitly passed on and thus API will always return effective date. This should resolve your issue. Thanks !

@logicsandeep
Copy link
Contributor Author

@suryayadavalli Will this change impact any existing client?

@suryayadavalli
Copy link
Contributor

@logicsandeep : This will not impact any existing clients. However, we will discuss this briefly in the meeting tomorrow and then before I proceed with the changes.

  • Currently submission date in client survey submission is NULL if effective date is not passed on while posting responses. As discussed, this submission date will be populated with the current date (the date when the responses are posted).
  • In the active list (eligible clients entity), currently survey submission is populated with the scores submitted date if effective date is NULL. However, this will be populated as the following.
  1. If effective date is NOT null, then consider effective date
  2. If effective date is NULL, then consider the date the responses are POSTed, or the date the scores are POSTed, which occurs first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants