Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change signature of Headers::{append,insert} #383

Closed
2 tasks
yoshuawuyts opened this issue Oct 8, 2021 · 2 comments · Fixed by #385
Closed
2 tasks

Change signature of Headers::{append,insert} #383

yoshuawuyts opened this issue Oct 8, 2021 · 2 comments · Fixed by #385
Assignees
@pepoviola
Labels
semver-major This change requires a semver major change
Milestone
3.0

Comments

@yoshuawuyts
Copy link
Member

yoshuawuyts commented Oct 8, 2021 •
edited
Loading

See http-rs/tide#853

Tasks

  • change signature of {Request,Response,Headers}::append to return Result
  • change signature of {Request,Response,Headers}::insert to return Result
@yoshuawuyts yoshuawuyts added the semver-major This change requires a semver major change label Oct 8, 2021
@yoshuawuyts yoshuawuyts added this to the 3.0 milestone Oct 8, 2021
@pepoviola
Copy link
Contributor

Hi @yoshuawuyts, I can take a look unless you are already working on this.
Thanks!

@yoshuawuyts
Copy link
Member Author

@pepoviola that'd be great, all yours!

@halvko halvko mentioned this issue Oct 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pepoviola pepoviola

Labels
semver-major This change requires a semver major change
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Change signature of insertion/appending of headers halvko/http-types
2 participants
@pepoviola @yoshuawuyts