Skip to content

Turn on TCP NO_DELAY by default? #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Fishrock123 opened this issue Aug 24, 2021 · 3 comments · May be fixed by #331
Open

Turn on TCP NO_DELAY by default? #322

Fishrock123 opened this issue Aug 24, 2021 · 3 comments · May be fixed by #331
Labels
semver-major

Comments

@Fishrock123
Copy link
Member

Fishrock123 commented Aug 24, 2021 •
edited
Loading

@ericsampson mentioned to me that a lot of http clients turn this on by default.

Some ecosystem stats:
@yoshuawuyts
Copy link
Member

Oh interesting; I vaguely remember TCP_NODELAY existing so that responses don't arrive from the future. But this may mostly be relevant for HTTP servers, less so for clients. The fact that most other clients do this makes it seem like we could probably too!

@ericsampson
Copy link

Yeah, my experience is from .NET and Java, both of which made this the default value for their HTTP client years ago for perf reasons.

Thanks!!

@Firstyear
Copy link

I'd support this change :)

u5surf added a commit to u5surf/surf that referenced this issue Nov 22, 2021
@u5surf
Turn on TCP NO_DELAY by default http-rs#322
0b704c8
@u5surf u5surf linked a pull request Nov 22, 2021 that will close this issue
Open
u5surf added a commit to u5surf/surf that referenced this issue Dec 7, 2021
@u5surf
Turn on TCP NO_DELAY by default http-rs#322
75c012f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
semver-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Turn on TCP NO_DELAY by default #322 u5surf/surf
4 participants
@Firstyear @Fishrock123 @ericsampson @yoshuawuyts