Revert sudo support - this makes more sense in the server

In practice, I think we'll always be triggering this as part of backend
logic, so that's cleaner. That also neatly solves my security concerns
about arbitrary commands here - we can use fixed commands in the server,
since the update mechanism there is much more effective (...for now).

Author: pimterry

package-lock.json

@@ -130,7 +130,6 @@
     "publish": null
   },
   "dependencies": {
-    "@expo/sudo-prompt": "^9.3.2",
     "@httptoolkit/util": "^0.1.8",
     "@sentry/electron": "^7.2.0",
     "electron-context-menu": "^3.5.0",

package.json

@@ -18,9 +18,8 @@ const rmRF = (p: string) => fs.rm(p, { recursive: true, force: true });
 
 import windowStateKeeper from 'electron-window-state';
 import { getSystemProxy } from 'os-proxy-config';
-import registerContextMenu from 'electron-context-menu';
-import * as sudoPrompt from '@expo/sudo-prompt';
-import { getDeferred, delay, ErrorLike } from '@httptoolkit/util';
+import registerContextMenu = require('electron-context-menu');
+import { getDeferred, delay } from '@httptoolkit/util';
 
 import { getMenu, shouldAutoHideMenu } from './menu.ts';
 import { ContextMenuDefinition, openContextMenu } from './context-menu.ts';
@@ -660,33 +659,3 @@ ipcMain.handle('restart-app', ipcHandler(() => {
     app.relaunch();
     app.quit();
 }));
-
-// Prompt the user to authorize a command to run as root, for system setup we can't do
-// without elevated permissions. We try to avoid this, but for system config changes
-// it's required, and much better to do per-command than running the whole app as root.
-ipcMain.handle('sudo', ipcHandler(async (options: {
-    command: string
-}) => {
-    if (typeof options?.command !== 'string') {
-        throw new Error("Invalid command for sudo");
-    }
-
-    const result = getDeferred<{ success: boolean, error?: ErrorLike, stdout: string, stderr: string }>();
-
-    sudoPrompt.exec(options.command, {
-        name: 'HTTP Toolkit'
-    }, (error: unknown | null, stdout: string, stderr: string) => {
-        // Types suggest this could be a buffer, but we want to
-        // enforce simpler string output:
-        stdout = stdout?.toString() ?? '';
-        stderr = stderr?.toString() ?? '';
-
-        if (error) {
-            result.resolve({ success: false, error, stdout, stderr });
-        } else {
-            result.resolve({ success: true, stdout, stderr });
-        }
-    });
-
-    return result.promise;
-}));

src/index.ts

@@ -46,8 +46,5 @@ contextBridge.exposeInMainWorld('desktopApi', {
         ipcRenderer.invoke('open-context-menu', options),
 
     restartApp: () =>
-        ipcRenderer.invoke('restart-app'),
-
-    sudo: (options: any) =>
-        ipcRenderer.invoke('sudo', options)
+        ipcRenderer.invoke('restart-app')
 });