Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document integration requirements #777

Open
adrinjalali opened this issue Mar 17, 2022 · 3 comments
Open

Document integration requirements #777

adrinjalali opened this issue Mar 17, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@adrinjalali
Copy link
Contributor

Taken from: huggingface/hub-docs#62 (comment), leaving it here since the repos are now separate.

Something we were just talking with @LysandreJik is that at the moment we don't have documentation on specifications of each integration.

Trying to explain:

Many of our integrations have been happening with close collaboration with third party developers. We would sometimes change something in the backend to support certain aspects of the new integration. For instance, the fastai integration adds dependencies to pyproject.toml and then those dependencies are installed somewhere, somehow, before the model is loaded.

What's missing is the kind of documentation explaining what exactly is required from a fastai repo on our side, for it to be properly interpreted and the inference API to work on it. It would be nice for a PR such as #678 to add that kind of documentation before being merged. This would also allow others to implement their own integration, even in a different language than Python if they need to. It would also give clarity to users on how their repos should look like.

@osanseviero
Copy link
Contributor

I like this idea!

At one point there was an idea of having a LIbraries page (internal issue: https://github.com/huggingface/moon-landing/issues/749) which would hold this information. Since most of the 3rd party library integrations are not within hub-docs, I don't think this should be documented here, but rather in huggingface_hub (except maybe for the 2 libraries integrated in huggingface_hub, and even then I would prefer all of them in a single place). WDYT?

@adrinjalali adrinjalali added the documentation Improvements or additions to documentation label Mar 31, 2022
@adrinjalali
Copy link
Contributor Author

I agree that the documentation should be where the implementation is. But isn't that api-inference-community then?

@osanseviero
Copy link
Contributor

As discussed offline, api-inference-community is focused in the API implementation and docker images, not in downstream and upstream integrations.

I think we will likely have a new libraries section in hf.co/docs/hub with a page for each library. I think that would be part of huggingface/hub-docs#62 (comment) and with the revamp of the Hub docs cc @NimaBoscarino

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants