-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs review #818
Comments
Also cc @NimaBoscarino. For context, this is about |
Opened #839 to take care of the general maintenance things. Next up, I'll work on something to address 1 and 2 :) |
Hi sorry for all these PRs! 😅 The plan moving forward is to:
For the third-party library integration guide, I don't think doing a step-by-step walkthrough really makes sense anymore because it is so specific to what/how the developer wants to do it. For example, the spaCy push integration looks quite different from the allennlp push integration (at least to my untrained eyes lol). As mentioned in #824, there are two ways to integrate a third-party library and we should center the guides around these:
|
I think the integration part also comes with product changes, so I think we can document this better in the new hub docs revamp, with links to |
Yeah thanks so much for all the work you've done! 🥳 |
This issue shares some feedback about the latest docs. Really interesting to come back and see what I had written a couple of months ago, let me know what you think! 😅
huggingface_hub
.Repository
class.Instead of linking to the guide for how to integrate third-party libraries with the Hub, we should have a page in the docs dedicated to it since it is quite important. In general, I think this guide could also be updated because it's not really obvious how to do the actual integration part, except for setting up the Inference API section. There aren't clear steps for how to integrate something like
snapshot_download
into a third-party library.It would be nice to pick a library - spaCy for example - and do a walkthrough on how they integrated
huggingface_hub
into their library. The catch is spaCy's integration may not be generalizable to all libraries. But I think at least showing this integration process would be really helpful.A few general housekeeping things I noticed:
hf_hub_url
].```
in Searching the Hub doc.To do
cc @LysandreJik @osanseviero
The text was updated successfully, but these errors were encountered: