You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current OTEL instrumentation does not output the agent names, which makes understanding multi-agent traces difficult (although confusingly enough it does output managed_agents). Instead of outputting "Step 1", it would be better to have "{agent.name} Step 1", same for "CodeAgent.run" - better "{agent.name} CodeAgent.run". Based on a quick hack, it seems that this can be improved simply by replacing span_name assignments in _wrappers.py (and maybe also by adding it to _smolagent_run_attributes).
Furthermore, given that Python execution errors are the most common type of errors occurring for CodeAgents during the runs, it is important that the actual Python code (not just error messages) is captured via OTEL. For that it seems like adding a _PythonExecutorWrapper similar to _ToolCallWrapper in _wrappers.py should be sufficient. (I got it to work with my LocalPythonExecutor, but I can't test it with other types, which is why I'm not providing a direct patch/PR.)
The text was updated successfully, but these errors were encountered:
The current OTEL instrumentation does not output the agent names, which makes understanding multi-agent traces difficult (although confusingly enough it does output managed_agents). Instead of outputting "Step 1", it would be better to have "{agent.name} Step 1", same for "CodeAgent.run" - better "{agent.name} CodeAgent.run". Based on a quick hack, it seems that this can be improved simply by replacing span_name assignments in _wrappers.py (and maybe also by adding it to _smolagent_run_attributes).
Furthermore, given that Python execution errors are the most common type of errors occurring for CodeAgents during the runs, it is important that the actual Python code (not just error messages) is captured via OTEL. For that it seems like adding a _PythonExecutorWrapper similar to _ToolCallWrapper in _wrappers.py should be sufficient. (I got it to work with my LocalPythonExecutor, but I can't test it with other types, which is why I'm not providing a direct patch/PR.)
The text was updated successfully, but these errors were encountered: